Skip to content

use stable foundry, update test:signatures and test:storage #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzeoneth merged 3 commits into from
Mar 10, 2025
Merged

use stable foundry, update test:signatures and test:storage #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4868c07
use stable foundry, update test:signatures and test:storage
godzillaba Feb 14, 2025
2b73fdf
storage
godzillaba Feb 14, 2025
f6050e2
snapshot
godzillaba Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ L2SecurityCouncilMgmtFactoryTest:testRemovalGovDeployment() (gas: 30526232)
L2SecurityCouncilMgmtFactoryTest:testSecurityCouncilManagerDeployment() (gas: 30545325)
NomineeGovernorV2UpgradeActionTest:testAction() (gas: 8153)
OfficeHoursActionTest:testConstructor() (gas: 9050)
OfficeHoursActionTest:testFuzzOfficeHoursDeployment(uint256,uint256,int256,uint256,uint256,uint256) (runs: 258, μ: 317071, ~: 317184)
OfficeHoursActionTest:testFuzzOfficeHoursDeployment(uint256,uint256,int256,uint256,uint256,uint256) (runs: 256, μ: 317072, ~: 317184)
OfficeHoursActionTest:testInvalidConstructorParameters() (gas: 235740)
OfficeHoursActionTest:testPerformBeforeMinimumTimestamp() (gas: 8646)
OfficeHoursActionTest:testPerformDuringOfficeHours() (gas: 9140)
Expand Down Expand Up @@ -153,7 +153,7 @@ SecurityCouncilMemberElectionGovernorTest:testOnlyNomineeElectionGovernorCanProp
SecurityCouncilMemberElectionGovernorTest:testProperInitialization() (gas: 49388)
SecurityCouncilMemberElectionGovernorTest:testProposeReverts() (gas: 32916)
SecurityCouncilMemberElectionGovernorTest:testRelay() (gas: 42229)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNominees(uint256) (runs: 258, μ: 339983, ~: 339822)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNominees(uint256) (runs: 256, μ: 339999, ~: 339822)
SecurityCouncilMemberElectionGovernorTest:testSelectTopNomineesFails() (gas: 273335)
SecurityCouncilMemberElectionGovernorTest:testSetFullWeightDuration() (gas: 34951)
SecurityCouncilMemberElectionGovernorTest:testVotesToWeight() (gas: 152898)
Expand Down Expand Up @@ -206,7 +206,7 @@ SequencerActionsTest:testAddAndRemoveSequencer() (gas: 483532)
SequencerActionsTest:testCantAddZeroAddress() (gas: 235614)
SetInitialGovParamsActionTest:testL1() (gas: 259904)
SetInitialGovParamsActionTest:testL2() (gas: 688888)
SetSequencerInboxMaxTimeVariationAction:testSetMaxTimeVariation() (gas: 374262)
SetSequencerInboxMaxTimeVariationActionTest:testSetMaxTimeVariation() (gas: 374262)
SwitchManagerRolesActionTest:testAction() (gas: 6313)
TokenDistributorTest:testClaim() (gas: 5742744)
TokenDistributorTest:testClaimAndDelegate() (gas: 5850827)
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Setup node/yarn
uses: actions/setup-node@v3
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Setup node/yarn
uses: actions/setup-node@v3
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Install packages
run: yarn
Expand All @@ -105,7 +105,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Install packages
run: yarn
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Setup node/yarn
uses: actions/setup-node@v3
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
version: stable

- name: Setup node/yarn
uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion test/gov-actions/SetSequencerInboxMaxTimeVariationAction.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import "../util/ActionTestBase.sol";
import "../../src/gov-action-contracts/sequencer/SetSequencerInboxMaxTimeVariationAction.sol" as
action;

contract SetSequencerInboxMaxTimeVariationAction is Test, ActionTestBase {
contract SetSequencerInboxMaxTimeVariationActionTest is Test, ActionTestBase {
uint256 public newDelayBlocks = 123;
uint256 public newFutureBlocks = 456;
uint256 public newDelaySeconds = 789;
Expand Down
13 changes: 13 additions & 0 deletions test/signatures/AIP1Point1Target
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@

╭----------------------------+------------╮
| Method | Identifier |
+=========================================+
| arbitrumFoundationWallet() | 3ebcaf8d |
|----------------------------+------------|
| effectuate() | 35c2fabe |
|----------------------------+------------|
| passed() | a05b5c30 |
|----------------------------+------------|
| treasuryTimelock() | 0c559659 |
╰----------------------------+------------╯

13 changes: 13 additions & 0 deletions test/signatures/AIP1Point2Action
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@

╭------------------------+------------╮
| Method | Identifier |
+=====================================+
| l2GovAddressRegistry() | 3f027cf7 |
|------------------------+------------|
| newConstitutionHash() | 8035cce0 |
|------------------------+------------|
| newProposalThreshold() | ed997f42 |
|------------------------+------------|
| perform() | b147f40c |
╰------------------------+------------╯

19 changes: 19 additions & 0 deletions test/signatures/AIP4844Action
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@

╭---------------------------+------------╮
| Method | Identifier |
+========================================+
| govProxyAdmin() | 8086e788 |
|---------------------------+------------|
| l1AddressRegistry() | 87dbdd81 |
|---------------------------+------------|
| newChallengeManagerImpl() | 924ef096 |
|---------------------------+------------|
| newOsp() | 5c4bb63c |
|---------------------------+------------|
| newSequencerInboxImpl() | d268538a |
|---------------------------+------------|
| newWasmModuleRoot() | 6741148c |
|---------------------------+------------|
| perform() | b147f40c |
╰---------------------------+------------╯

11 changes: 11 additions & 0 deletions test/signatures/AIP4Action
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

╭------------------------+------------╮
| Method | Identifier |
+=====================================+
| l2GovAddressRegistry() | 3f027cf7 |
|------------------------+------------|
| newConstitutionHash() | 8035cce0 |
|------------------------+------------|
| perform() | b147f40c |
╰------------------------+------------╯

11 changes: 11 additions & 0 deletions test/signatures/AIPArbOS31AddWasmCacheManagerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

╭----------------------+------------╮
| Method | Identifier |
+===================================+
| perform() | b147f40c |
|----------------------+------------|
| targetArbOSVersion() | fcb528a2 |
|----------------------+------------|
| wasmCachemanager() | b6763099 |
╰----------------------+------------╯

21 changes: 21 additions & 0 deletions test/signatures/AIPArbOS31UpgradeChallengeManagerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

╭---------------------------+------------╮
| Method | Identifier |
+========================================+
| condOsp() | acdf78b9 |
|---------------------------+------------|
| condRoot() | 828545a7 |
|---------------------------+------------|
| govProxyAdmin() | 8086e788 |
|---------------------------+------------|
| l1AddressRegistry() | 87dbdd81 |
|---------------------------+------------|
| newChallengeManagerImpl() | 924ef096 |
|---------------------------+------------|
| newWasmModuleRoot() | 6741148c |
|---------------------------+------------|
| osp() | f26a62c6 |
|---------------------------+------------|
| perform() | b147f40c |
╰---------------------------+------------╯

45 changes: 45 additions & 0 deletions test/signatures/AIPNovaFeeRoutingAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@

╭-------------------------+------------╮
| Method | Identifier |
+======================================+
| fullWeight() | 94332b84 |
|-------------------------+------------|
| l1GovTimelockAlias() | d355a34a |
|-------------------------+------------|
| novaL1SurplusFeeDistr() | c8cbc619 |
|-------------------------+------------|
| novaL2BaseFeeDistr() | 4b8e71cd |
|-------------------------+------------|
| novaL2BaseRecipient1() | 81368c17 |
|-------------------------+------------|
| novaL2BaseRecipient2() | 4d379437 |
|-------------------------+------------|
| novaL2BaseRecipient3() | fc7e7c00 |
|-------------------------+------------|
| novaL2BaseRecipient4() | 21292354 |
|-------------------------+------------|
| novaL2BaseRecipient5() | 6f74efd1 |
|-------------------------+------------|
| novaL2BaseRecipient6() | 48ec2953 |
|-------------------------+------------|
| novaL2BaseWeight0() | 88b636e7 |
|-------------------------+------------|
| novaL2BaseWeight1() | 71a7b9c3 |
|-------------------------+------------|
| novaL2BaseWeight2() | 3821e637 |
|-------------------------+------------|
| novaL2BaseWeight3() | a75bcd51 |
|-------------------------+------------|
| novaL2BaseWeight4() | 0728d152 |
|-------------------------+------------|
| novaL2BaseWeight5() | 61c61d04 |
|-------------------------+------------|
| novaL2BaseWeight6() | 772f8546 |
|-------------------------+------------|
| novaL2SurplusFeeDistr() | 57aa21f3 |
|-------------------------+------------|
| novaToL1Router() | 1e3cb33a |
|-------------------------+------------|
| perform() | b147f40c |
╰-------------------------+------------╯

17 changes: 17 additions & 0 deletions test/signatures/AIPSetSequencerInboxMaxTimeVariationArbOneAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

╭------------------+------------╮
| Method | Identifier |
+===============================+
| delayBlocks() | ad9c0c2e |
|------------------+------------|
| delaySeconds() | b752a7d1 |
|------------------+------------|
| futureBlocks() | 4f359a37 |
|------------------+------------|
| futureSeconds() | 2f1ec5e9 |
|------------------+------------|
| perform() | b147f40c |
|------------------+------------|
| sequencerInbox() | ee35f327 |
╰------------------+------------╯

17 changes: 17 additions & 0 deletions test/signatures/AIPSetSequencerInboxMaxTimeVariationNovaAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

╭------------------+------------╮
| Method | Identifier |
+===============================+
| delayBlocks() | ad9c0c2e |
|------------------+------------|
| delaySeconds() | b752a7d1 |
|------------------+------------|
| futureBlocks() | 4f359a37 |
|------------------+------------|
| futureSeconds() | 2f1ec5e9 |
|------------------+------------|
| perform() | b147f40c |
|------------------+------------|
| sequencerInbox() | ee35f327 |
╰------------------+------------╯

11 changes: 11 additions & 0 deletions test/signatures/ActionCanExecute
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

╭-----------------------+------------╮
| Method | Identifier |
+====================================+
| canExecute() | 78b90337 |
|-----------------------+------------|
| owner() | 8da5cb5b |
|-----------------------+------------|
| setIsExecutable(bool) | b65144fb |
╰-----------------------+------------╯

11 changes: 11 additions & 0 deletions test/signatures/ActionExecutionRecord
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

╭---------------------+------------╮
| Method | Identifier |
+==================================+
| actionContractId() | 22d2fa9b |
|---------------------+------------|
| computeKey(uint256) | f1cea490 |
|---------------------+------------|
| store() | 975057e7 |
╰---------------------+------------╯

7 changes: 7 additions & 0 deletions test/signatures/AddChainOwnerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

╭------------------+------------╮
| Method | Identifier |
+===============================+
| perform(address) | b38ed43b |
╰------------------+------------╯

13 changes: 13 additions & 0 deletions test/signatures/AddNovaKeysetAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@

╭---------------+------------╮
| Method | Identifier |
+============================+
| keysetBytes() | c15e424c |
|---------------+------------|
| keysetHash() | 31d5d6cd |
|---------------+------------|
| novaInbox() | 4d644050 |
|---------------+------------|
| perform() | b147f40c |
╰---------------+------------╯

9 changes: 9 additions & 0 deletions test/signatures/AddSequencerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

╭-------------------+------------╮
| Method | Identifier |
+================================+
| addressRegistry() | f3ad65f4 |
|-------------------+------------|
| perform(address) | b38ed43b |
╰-------------------+------------╯

19 changes: 19 additions & 0 deletions test/signatures/ArbGoerliSetInitialGovParamsAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@

╭--------------------------+------------╮
| Method | Identifier |
+=======================================+
| coreTimelockPeriod() | 2dcea2a7 |
|--------------------------+------------|
| coreVotingDelay() | 2abeab10 |
|--------------------------+------------|
| coreVotingPeriod() | caa1451e |
|--------------------------+------------|
| perform() | b147f40c |
|--------------------------+------------|
| treasuryTimelockPeriod() | 11ac088a |
|--------------------------+------------|
| treasuryVotingDelay() | 1b6e2b3c |
|--------------------------+------------|
| treasuryVotingPeriod() | aac9f709 |
╰--------------------------+------------╯

19 changes: 19 additions & 0 deletions test/signatures/ArbOneAIP4844Action
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@

╭---------------------------+------------╮
| Method | Identifier |
+========================================+
| govProxyAdmin() | 8086e788 |
|---------------------------+------------|
| l1AddressRegistry() | 87dbdd81 |
|---------------------------+------------|
| newChallengeManagerImpl() | 924ef096 |
|---------------------------+------------|
| newOsp() | 5c4bb63c |
|---------------------------+------------|
| newSequencerInboxImpl() | d268538a |
|---------------------------+------------|
| newWasmModuleRoot() | 6741148c |
|---------------------------+------------|
| perform() | b147f40c |
╰---------------------------+------------╯

11 changes: 11 additions & 0 deletions test/signatures/ArbOneAIPArbOS31AddWasmCacheManagerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

╭----------------------+------------╮
| Method | Identifier |
+===================================+
| perform() | b147f40c |
|----------------------+------------|
| targetArbOSVersion() | fcb528a2 |
|----------------------+------------|
| wasmCachemanager() | b6763099 |
╰----------------------+------------╯

21 changes: 21 additions & 0 deletions test/signatures/ArbOneAIPArbOS31UpgradeChallengeManagerAction
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

╭---------------------------+------------╮
| Method | Identifier |
+========================================+
| condOsp() | acdf78b9 |
|---------------------------+------------|
| condRoot() | 828545a7 |
|---------------------------+------------|
| govProxyAdmin() | 8086e788 |
|---------------------------+------------|
| l1AddressRegistry() | 87dbdd81 |
|---------------------------+------------|
| newChallengeManagerImpl() | 924ef096 |
|---------------------------+------------|
| newWasmModuleRoot() | 6741148c |
|---------------------------+------------|
| osp() | f26a62c6 |
|---------------------------+------------|
| perform() | b147f40c |
╰---------------------------+------------╯

Loading
Loading