-
Notifications
You must be signed in to change notification settings - Fork 7
Self hosting improvements #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - [`storage`](#storage-configuration) - Configures persistent storage | ||
| - [`telemetry`](#telemetry-configuration) - Configures telemetry and observability (OTEL) | ||
| - [`tools`](#tools-configuration) - Configures tools for AI models to use | ||
| <TableOfContents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably outside of this PR, but I think we should indicate that these rows are links somehow, not just a table.
| description: "Arcade Engine Configuration Overview" | ||
| --- | ||
|
|
||
| import { Tabs } from "nextra/components"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Engine Config Templates | ||
|
|
||
| **engine.yaml** | ||
| ### engine.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes it so that i can link to this from other pages
| const handleRowClick = (firstColumnValue) => { | ||
| // Convert first column value to a valid ID format | ||
| const sectionId = firstColumnValue.toLowerCase().replace(/\s+/g, ""); | ||
| const sectionId = firstColumnValue.toLowerCase().replace(/\s+/g, "-"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that table of contents section names can have spaces and still be linked to a specific section on the page
| - [`storage`](#storage-configuration) - Configures persistent storage | ||
| - [`telemetry`](#telemetry-configuration) - Configures telemetry and observability (OTEL) | ||
| - [`tools`](#tools-configuration) - Configures tools for AI models to use | ||
| <TableOfContents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably outside of this PR, but I think we should indicate that these rows are links somehow, not just a table.
|
@wdawson the rows in the TableOfContents will react when hovered over. Do you think this is enough of an indication, or are you thinking of an underline + link highlight in addition? For example check out the TOC on this page https://docs.arcade.dev/toolkits/development/github/github |
I think it's enough for now. But I'd like something else. Not sure what exactly. |




Some improvements to local hosting related docs. Most is visual improvements, but there are also some additions for clarification