Replace user ID in examples with Arcade account email (if logged in) #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evantahler
reviewed
Jul 10, 2025
Contributor
evantahler
left a comment
evantahler
left a comment
There was a problem hiding this comment.
FWIW, the preview environment doesn't work for me, and I am signed on both bosslevel and prod
Comment on lines
9
to
11
| const replacement = loading | ||
| ? "{arcade_user_id}" // Keep original while loading | ||
| : email || "{arcade_user_id}"; |
sdserranog
approved these changes
Jul 11, 2025
| import { useOrySession } from "@/lib/OrySessionContext"; | ||
| import { getCookie } from "@/lib/utils"; | ||
|
|
||
| export function PlaceholderReplacer() { |
Contributor
There was a problem hiding this comment.
No need to change this now, but for the future. This approach can be a bit expensive. It searches every single text element on the page to find the placeholder and then mutates the DOM after the page has loaded.
We could improve this later in a couple of ways:
- Create a dedicated component to show the examples that consumes our OryContextProvider. So we can search/replace the placeholder only in the example.
- Use a Server Component to read the cookie and replace the placeholder on the server, which would prevent any client-side DOM mutation for the initial load.
sdserranog
reviewed
Jul 11, 2025
| useEffect(() => { | ||
| const checkSession = async () => { | ||
| try { | ||
| const { data: session } = await ory.toSession(); |
Contributor
There was a problem hiding this comment.
I think we can also use a server component here to avoid a loading state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the quickstart and code examples easier to follow, this PR replaces all sample user IDs like
[email protected]with a placeholder with either:"{arcade_user_id"}if notThis change will help reduce confusion especially when #341 is merged.