Remove PyPI badges from toolkit headers#896
Merged
Conversation
We're removing toolkit packages from PyPI, so the docs should no longer advertise package metadata in the header. Add a regression test and remove the unused header badge wiring. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sdserranog
reviewed
Mar 31, 2026
app/_components/logo.tsx
Outdated
Contributor
There was a problem hiding this comment.
Can we use named imports instead of using the barrel import?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolkitHeaderidprop wiringTest plan
pnpm test -- toolkit-docs-generator/tests/app-lib/toolkit-header.test.tsxpnpm exec ultracite check app/_components/toolkit-docs/constants.ts app/_components/toolkit-docs/components/toolkit-header.tsx app/_components/toolkit-docs/components/toolkit-page.tsx app/_components/toolkit-docs/index.ts app/_components/toolkit-docs/types/index.ts toolkit-docs-generator/tests/app-lib/toolkit-header.test.tsxMade with Cursor
Note
Low Risk
Low risk UI-only change that removes rendered markup and a now-unused prop/constants; main risk is minor layout/regression on toolkit header rendering.
Overview
Toolkit documentation headers no longer render PyPI/license badges. The
ToolkitHeadercomponent drops theidprop and removes the badge-strip markup that linked to PyPI and the project license.This also deletes the associated badge/URL constants from
toolkit-docs/constants.ts, updatesToolkitPageand the publictoolkit-docsmodule docs to stop wiring/publishingid, and adjusts the globalLogoicon import to the new design-system icon path.Written by Cursor Bugbot for commit 2f7ef98. This will update automatically on new commits. Configure here.