Remove environment as required so that env vars can be source of truth. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modifies the telemetry configuration schema to make the environment field optional, allowing environment variables to serve as the source of truth when the config field is not specified. The change removes environment from the required fields and updates its description to clarify that it overrides environment variables when present.
Key Changes:
- Made the
environmentfield optional in the telemetry configuration schema - Updated the field description to clarify override behavior
- Removed the example environment variable reference from the sample configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| engine/config/1.0/schema.json | Removed environment from required fields and updated description to clarify override semantics |
| engine/config/1.0/example.yaml | Removed the example usage of environment field with environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evantahler
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine uses the config as the source of truth, instead of env vars being able to override the config.