Nate/embedded postgres tweak #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarbettini
commented
Dec 19, 2025
| "description": "Configures the persistent storage system.", | ||
| "properties": { | ||
| "embedded": { | ||
| "in_memory": { |
Contributor
Author
There was a problem hiding this comment.
Reverted all the changes to 1.0/schema.json since we are using 2.0 to break backwards compatibility. I think we want to keep 1.0 where it is - lmk if I'm missing something.
| "db": { | ||
| "type": "string", | ||
| "description": "The database name. Required for external mode." | ||
| "oneOf": [ |
Contributor
Author
There was a problem hiding this comment.
oneOf encodes the mutual-exclusivity that we describe in data_path.description at the schema level. So the schema will validate with either data_path or host/port/user/etc but not with both.
| }, | ||
| { | ||
| "type": "null", | ||
| "description": "No storage configuration is set. Uses embedded PostgreSQL with default settings." |
Contributor
Author
There was a problem hiding this comment.
Removed this because it was kinda hard to understand. Technically we allowed storage: null which meant embedded, but I think it's much clearer to just declare what you have now:
storage:
postgres:
data_path: "..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments inline below