-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add background audio playback for voice messages #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a9832c9
Make audio view use Media3 for playback
wchen342 9a121b3
Fix UI update problems;
wchen342 4bd7432
Try to decouple view and business logics
wchen342 b74e793
Finish ViewModel for audio playback; Refine UI set up for AudioView
wchen342 7683408
Allow going back to previous activity from the notification; Support …
wchen342 11f3964
Add support for attachment draft; Distinguish between different messages
wchen342 59139ed
Add support for attachment draft; Distinguish between different messa…
wchen342 34be7aa
Cleanup imports
wchen342 1ff4e06
Merge branch 'main' into wch423/audio-background-play
adbenitez 13374df
Bug fixes and minor changes
wchen342 10acb07
Make device messages and subscribed channels edge to edge
wchen342 93f12e7
Make message list respect bottom bar height
wchen342 f319ba2
Allow list scrolling to extend to edge
wchen342 aebd5c6
Merge branch 'main' into wch423/audio-background-play
adbenitez b66bc1f
Handle specific case when leaving group; also move floating button to…
wchen342 71ed333
Stop playback when attachment preview is removed;
wchen342 5e6fccf
Merge branch 'main' into wch423/edge-to-edge-device-channel
adbenitez 2889266
Force dispatch all inset changes immediately in ConversationFragment
wchen342 cebfa12
Merge branch 'main' into wch423/edge-to-edge-device-channel
adbenitez 82118db
Make inset changes only happen on initialization of activity
wchen342 57eead3
Merge branch 'main' into wch423/edge-to-edge-device-channel
adbenitez 3386f5c
Make `!CanSend` -> `CanSend` still trigger Inset changes
wchen342 f022316
Merge branch 'main' into wch423/audio-background-play
adbenitez 1c174b5
Stop draft audio playback when (1) the conversation exits; or (2) the…
wchen342 2704749
Merge pull request #4198 from deltachat/wch423/edge-to-edge-device-ch…
wchen342 9ffc904
more detailed call strings
r10s 30124de
Merge branch 'main' into wch423/audio-background-play
adbenitez 93427ba
Merge remote-tracking branch 'upstream/wch423/audio-background-play' …
adbenitez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AudioPlaybackServiceis declaredandroid:exported="true", which allows any other app to connect as a Media3 controller. Given the currentonConnectimplementation accepts all controllers and exposes a custom command, this becomes a security boundary issue. If external control isn't required, setexported="false"; otherwise explicitly restrict allowed controllers (e.g., same package UID / system UI) and only expose custom commands to trusted callers.