Skip to content

Conversation

@Seldom-SE
Copy link
Collaborator

What is this fixing or adding?

Update logic to account for changes in Calamity mod 2.0.7. Most notably, many ores can no longer be obtained from fishing crates. I'll write a review describing the changes.

This is blocking a fix for Seldom-SE/archipelago_terraria_client#17. Calamity made a breaking change, and currently players have to manually downgrade Calamity or use an .apworld of these changes, which conflicts with information in the setup guide.

How was this tested?

I made a testing release of this a couple weeks ago. I saw it get a fair amount of use, and no logic bugs were found with it.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 3, 2026
@Seldom-SE Seldom-SE added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Jan 3, 2026
Meteorite; ; #Evil Boss | Evil Boss | Meteorite Bar | (@calamity & Astral Infection);
Meteorite Bar; ; Meteorite | (@calamity & Astral Infection) | Meteor Staff;
Meteorite; ; #Evil Boss | Evil Boss | Meteorite Bar;
Meteorite Bar; ; Meteorite | Meteor Staff;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Monolith Crate and Astral Crate were able to contain Meteorite or Meteorite Bars

The Perforators; Calamity | Location | Item;
Blood Sample; Calamity; #The Perforators;
Aerialite Ore; Calamity; The Hive Mind | The Perforators | Cobalt Ore | Aerialite Bar; // No pick needed; can be fished
Aerialite Ore; Calamity; The Hive Mind | The Perforators | Cobalt Ore | Aerialite Bar; // No pick needed; Aero Slime drops it
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, The Hive Mind or The Perforators flag allowed Sky Crate and Azure Crate to contain Aerialite. No logic change was needed, since those flags also allow Aero Slime to spawn, which drops Aerialite.

Titan Heart; Calamity; Astral Infection;
Essence of Sunlight; Calamity; Wall of Flesh | Golem;
Essence of Eleum; Calamity; Wall of Flesh | Cryogen | #Cryogen | (@getfixedboi & #Duke Fishron);
Essence of Sunlight; Calamity; Wall of Flesh | #Golem;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.7 prevented some crates from dropping Essence of Sunlight, but that didn't require a logic change, since you can get it from other sources in Hardmode. This is an unrelated bug. Golem drops Essence of Sunlight; its flag doesn't give you access to it.

Essence of Sunlight; Calamity; Wall of Flesh | Golem;
Essence of Eleum; Calamity; Wall of Flesh | Cryogen | #Cryogen | (@getfixedboi & #Duke Fishron);
Essence of Sunlight; Calamity; Wall of Flesh | #Golem;
Essence of Eleum; Calamity; Wall of Flesh | #Frost Legion | Cryogen | #Cryogen | (@getfixedboi & #Duke Fishron);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.7 prevented some crates from dropping Essence of Eleum in Hardmode, but that didn't require a logic change, since you can get it from other sources in Hardmode. But I noticed that some Frost Legion enemies drop Essence of Eleum and I wanted that to be reflected in logic so it doesn't confuse me when I look at it later, even though that doesn't actually affect logic.

// Brimstone Elemental
Infernal Suevite; Calamity; @pickaxe(150) | Brimstone Elemental;
Unholy Core; Calamity; (Infernal Suevite & Hellstone) | Brimstone Elemental;
Unholy Core; Calamity; Infernal Suevite & Hellstone;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Brimstone Elemental flag allowed Slag Crate and Brimstone Crate to drop Unholy Cores

Astral Ore; Calamity; (Astral Infection & Astrum Deus) | Astral Bar; // No pick needed; you can fish it
Astral Bar; Calamity; (Ancient Manipulator & Stardust & Astral Ore) | (Astral Infection & Astrum Deus);
Astral Ore; Calamity; (Astral Infection & Astrum Deus) | Astral Bar; // No pick needed; Astral Slime drops it
Astral Bar; Calamity; Ancient Manipulator & Stardust & Astral Ore;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Astrum Deus flag allowed Astral Crate to drop Astral Ore and Astral Bars. I changed logic for Astral Bar, but Astral Ore is still obtainable from Astral Slime, which is also blocked behind Astral Infection and Astrum Deus flag.

Meowmere; ; #Moon Lord;
Star Wrath; ; #Moon Lord;
Exodium Cluster; Calamity; Moon Lord | Uelibloom Ore; // No pick needed; can be fished
Exodium Cluster; Calamity; (Moon Lord & (Wall of Flesh | @pickaxe(225))) | Uelibloom Ore;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Moon Lord flag allowed Sky Crate and Azure Crate to drop Exodium Clusters. The Moon Lord flag still spawns Exodium Clusters and allows Shockstorm Shuttles to drop them, but the former requires mining and the latter only spawns in Hardmode.

Exodium Cluster; Calamity; (Moon Lord & (Wall of Flesh | @pickaxe(225))) | Uelibloom Ore;
Normality Relocator; Calamity; Ancient Manipulator & Rod of Discord & Exodium Cluster & Fragment;
Unholy Essence; Calamity; Moon Lord | #Providence, the Profaned Goddess | (Hallow & Providence, the Profaned Goddess) | (@getfixedboi & Plantera);
Unholy Essence; Calamity; Moon Lord | #Providence, the Profaned Goddess | (@getfixedboi & Plantera);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Providence flag allowed Hallowed Crate and Divine Crate to drop Unholy Essence. Fortunately, that was removed, since this was a particularly annoying piece of logic.

Tarragon Armor; Calamity | Armor Minions(3); Ancient Manipulator & Uelibloom Bar & Divine Geode;
Necromantic Geode; Calamity; #Ravager & Providence, the Profaned Goddess;
Bloodstone; Calamity; Providence, the Profaned Goddess;
Bloodstone; Calamity; Providence, the Profaned Goddess | Necromantic Geode;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bloodstone was obtainable from crates with Providence flag, but that never affected logic, since enemies drop it with that flag anyway. I just noticed Necromantic Geode logic was missing. In this case, I don't think that meaningfully affects logic, since Necromantic Geode is only obtainable with Providence flag anyway.

Yharon Soul Fragment; Calamity; #Yharon, Dragon of Rebirth | The Wand | Auric Bar;
The Wand; Calamity; (Cosmic Anvil & Wand of Sparking & Yharon Soul Fragment) | (@getfixedboi & #The Devourer of Gods);
Auric Ore; Calamity; (Yharon, Dragon of Rebirth & (@pickaxe(250) | Wall of Flesh)) | Auric Bar;
Auric Ore; Calamity; (Yharon, Dragon of Rebirth & @pickaxe(250)) | Auric Bar | Yharon Soul Fragment;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until 2.0.7, Yharon flag allowed Titanium Crate to drop Auric Ore. Also, 2.0.7 allows you to craft Auric Ore from Yharon Soul Fragments at Shimmer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant