Add capability to hard fail an item and kill the pipeline#114
Open
Ghostofapacket wants to merge 2 commits intoArchiveTeam:developmentfrom
Open
Add capability to hard fail an item and kill the pipeline#114Ghostofapacket wants to merge 2 commits intoArchiveTeam:developmentfrom
Ghostofapacket wants to merge 2 commits intoArchiveTeam:developmentfrom
Conversation
To allow the pipeline to completely crash. (Not to be used for warrior jobs!)
chfoo
reviewed
Sep 2, 2019
Member
chfoo
left a comment
chfoo
left a comment
There was a problem hiding this comment.
I don't see any major issues. I can pull once that syntax is clarified
| if item["ExternalProcess.running"]: | ||
| return | ||
| Task.fail_item(self, item) | ||
| if self.hard_exit == True: |
Member
There was a problem hiding this comment.
From what I see, hard_exit is already a boolean so it's redundant to compare it to another boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used for cloud scale deployments where autorespawn is required. Will break the warrior.