-
Notifications
You must be signed in to change notification settings - Fork 2
Update Dark mode #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Dark mode #13
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
txase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few small fixups, but otherwise this looks great!
| --sidebar-primary: white; | ||
| --sidebar-primary-foreground: var(--color-neutral-950); | ||
| --sidebar-accent: var(--color-neutral-800); | ||
| --base: oklch(25% 0.015 250); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if you tried the tailwindcss slate, gray, or zinc colors? An arbitrary base is fine, just wondering if it's worth using one of their standard colors so it's easier to read this value for what it is. Or maybe a comment about how it's close to a gray-800?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to a dark gray-blue base color and prioritize lum delta for color variations for better readability and reduced eye strain
994ddff to
354082a
Compare


These changes revisit our dark mode theme, switching from a pure black background with with foreground to a dark gray-blue with a slightly muted foreground.