Skip to content

Conversation

@ajantrania
Copy link
Member

@ajantrania ajantrania commented Nov 17, 2025

These changes revisit our dark mode theme, switching from a pure black background with with foreground to a dark gray-blue with a slightly muted foreground.

@ajantrania ajantrania requested a review from txase November 17, 2025 02:13
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.81% 1461 / 2933
🔵 Statements 50.11% 1513 / 3019
🔵 Functions 38.86% 239 / 615
🔵 Branches 45.8% 765 / 1670
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/ELKEdge.tsx 7.89% 0% 0% 8.1% 18-30, 34-71, 82-105
src/Flow.css 100% 100% 100% 100%
src/QueryGraph.tsx 29.78% 15% 38.09% 28.88% 59-94, 124-131, 140-162, 216-329
src/ResourceNode.tsx 53.77% 59.77% 40.9% 53.77% 67-82, 105-108, 177-186, 194, 196, 207-228, 238-259, 288, 303-467
src/ResourcesTable.tsx 48.14% 36% 55.17% 50% 29-30, 42, 51, 67, 93-100, 127-154, 161, 183-184, 193, 216
src/components/ResourceIcons.tsx 72.22% 69.23% 60% 71.69% 31-32, 58-59, 113, 117, 143, 149, 153, 159-169, 178
Generated in workflow #33 for commit 354082a by the Vitest Coverage Report Action

Copy link
Member

@txase txase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few small fixups, but otherwise this looks great!

--sidebar-primary: white;
--sidebar-primary-foreground: var(--color-neutral-950);
--sidebar-accent: var(--color-neutral-800);
--base: oklch(25% 0.015 250);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if you tried the tailwindcss slate, gray, or zinc colors? An arbitrary base is fine, just wondering if it's worth using one of their standard colors so it's easier to read this value for what it is. Or maybe a comment about how it's close to a gray-800?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tailwind gray scale is a bit more blue than what I had here, but I think it works (though gray-900 is closer). I'll switch to that

image

For another PR, but this is the WWW following a similar theme:
image

Switch to a dark gray-blue base color and prioritize lum delta for color variations for better readability and reduced eye strain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants