Use indicatif for progress bars#8
Conversation
|
I'm not 100% sure I want to use |
|
I think the flickering is an artifact of asciinema tbh - it looks smooth on my screen (TM). Might be an idea to include both UIs then, and hide them behind feature flags? |
|
Ah okay, I was wondering if it was due to asciinema. Including them both behind feature flags is fine with me as long as it's clean. BTW this should also be using |
also add rustfmt.toml
fabianfreyer
force-pushed
the
indicatif
branch
2 times, most recently
from
6020b41 to
66067ff
Compare
|
Like that? |
Keep the old pbr UI behind a feature flag.
| downloader.download::<rget::ui::multibar::MultibarUi, _>(input, matches.value_of("OUTPUT")) | ||
|
|
||
| if let Err(f) = downloader | ||
| .download::<rget::ui::multibar_indicatif::MultibarUi, _>(input, matches.value_of("OUTPUT")) |
There was a problem hiding this comment.
This should pick the progress bar setup based on available features rather than being hard-coded to indicatif.
2 participants
builds on the
refactorbranch.indicatif has some nicer, stylable, progress bars: