Flake8 fixes for new version of flake8 #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not assigned to, do not need the global declaration
not assigned to, global is incorrect
Contributor
|
@peterbarker do we really want this in 4.6 backports? I'm not sure how we backport a MAVProxy PR |
Contributor
Author
Sorry, missed. ping me if there are failures in the flake8 stuff on the backport branch, please, I'm pretty sure we'll need some... Also the patches from me to move the VMs forward to a newer version of Ubuntu... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Became a lot touchier about global keyword!