Skip to content

Conversation

@Ryanf55
Copy link
Contributor

Ryanf55 commented Jun 16, 2025

How can we run the new workflow to verify it works? Do we have to merge, then wait for the next calendar week to start?

@cclauss
Copy link
Contributor Author

cclauss commented Jun 16, 2025

Merge it, and (if needed) a new pull request will normally be created within about 15 minutes.

Example:

@Ryanf55
Copy link
Contributor

Ryanf55 commented Jun 17, 2025

This reduces maintenance burden of MAVProxy. I would like to try it. Approved!

@peterbarker
Copy link
Contributor

We could... but the PRs are likely to be ignored like the pnes for pymavlink are: https://github.com/ArduPilot/pymavlink/pulls?page=2&q=is%3Apr+is%3Aopen

@Ryanf55
Copy link
Contributor

Ryanf55 commented Jun 17, 2025

Better than waiting till the github actions are totally dead and CI breaks though?

@cclauss
Copy link
Contributor Author

cclauss commented Jun 17, 2025

the PRs are likely to be ignored

GitHub Actions are only used at CI test-time, while most other dependencies are also used at runtime.
This means that if the CI tests pass, maintainers have more confidence that the proposed changes will not break runtime.

GitHub Actions have very infrequent major version changes . setup-python, the most frequent, has only had four major upgrades in its lifetime.

When GitHub Actions are upgraded, it often happens in batches. The pattern: * proposed in this PR will consolidate all GHA updates into a single pull request to further reduce chattiness. Please see the example output provided above.

There is a tradeoff between supply chain security and chattiness. Given that we have a few GHAs that are updated rarely and usually in batches, and we are using pattern: * to ensure that there will only ever be a single GHA upgrade PR at a time.

@rmackay9
Copy link
Contributor

The author ping'd me about this so I've added it to the EUDevCall. I'm not really qualified to review the PR

@cclauss
Copy link
Contributor Author

cclauss commented Jun 29, 2025

Are there any remaining questions or todos on this one?

@tridge tridge merged commit 3ef5734 into ArduPilot:master Jul 24, 2025
2 checks passed
@cclauss cclauss deleted the patch-1 branch July 24, 2025 21:55
@cclauss
Copy link
Contributor Author

cclauss commented Jul 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants