camera_projection.py: Fix undefined names 'json' and 'self' #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Jul 15, 2025
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Wrong fix. Should be using data['version'] not self.version.
.... this doesn't make any sense as a change as it's creating an objet and self makes no sense. I can't see how this could possibly have been tested.
flake8 rule F821 -- Undefined names have the potential to raise NameError at runtime. `import json` needed for lines 64 and 106. `self` needed for line 87.
peterbarker
approved these changes
Aug 6, 2025
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
I might have moved to using f-string and a ValueError, but this is definitely better!
Contributor
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 rule F821 -- Undefined names have the potential to raise NameError at runtime.
import jsonneeded for lines 64 and 106.selfneeded for line 87.Line 87 mistakenly used
self.