horizon: fix oversized text on HiDPI displays #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't have a non Mac/Retina setup to test this on at the moment to make sure that it doesn't have detrimental affects on other machines, but it does fix it on Mac. |
Contributor
|
This causes the display to utterly freeze on Ubuntu when I resize it. It does do nice things to the font scaling, 'though :-) |
Avoids a potential resize loop as far as I can tell. Ubuntu and MacOS deal with DPI differently in the matplotlib library and I currently can only test MacOS Needs Testing!
peterbarker
approved these changes
Dec 30, 2025
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
So I don't really like this. Pretty sure there's got to be a better way to do things than use a fixed value - something else has to be going wrong here somewhere.
But it does fix the display for me, and it's a problem for @rbeall , so it'll do for now.
Merging, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Recent matplotlib versions (3.5+) report the actual display DPI on HiDPI/Retina screens. The font scaling in calcFontScaling() multiplies by figure.dpi, which now returns ~200 on Retina displays instead of the expected 100, causing all text to render at 2x size.
Fix by using a fixed reference DPI of 100 for the font calculations.
How Tested: