Close local file handle on session terminate #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a PermissionError that occurred when saving complete.param on subsequent downloads by ensuring the file handle is properly closed before clearing its reference in the __terminate_session() method.
Key Changes:
- Added proper file handle cleanup in
__terminate_session()to closeself.fhbefore setting it toNone - Added error handling with logging for any exceptions during file close operations
- Used try-except-finally pattern to ensure
self.fhis always set toNoneeven if close fails
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
Test Results 3 files 3 suites 31m 41s ⏱️ Results for commit 28ca460. ♻️ This comment has been updated with latest results. |
Close self.fh in __terminate_session() before clearing it so the OS file descriptor is released. This prevents PermissionError when saving complete.param on subsequent downloads. Log any close errors for diagnostics. Closes #1151
amilcarlucas
force-pushed
the
fix_1151
branch
from
06af460 to
28ca460
Compare
amilcarlucas
added a commit
that referenced
this pull request
Dec 24, 2025
…or installer downloads - Make vehicles/templates backup optional (default off) - Add _compute_sha256() helper and verify downloaded installer when expected SHA256 provided - Use non-vehicles backup by default in update flows Ref: update resilience and security for software update process
amilcarlucas
added a commit
that referenced
this pull request
Dec 24, 2025
- Add get_expected_sha256_from_release() to parse checksum assets or release body - Pass expected SHA256 to download_and_install_on_windows in update manager - Improve installer verification before execution
amilcarlucas
added a commit
that referenced
this pull request
Dec 24, 2025
- Add download_and_install_wheel_asset() helper - Prefer release wheel assets for non-Windows installs and verify SHA256 - Fallback to pip install when no wheel asset is available
amilcarlucas
added a commit
that referenced
this pull request
Dec 27, 2025
- Add retries, exponential backoff and jitter - Support HTTP Range resume when allowed - Preserve progress callback behavior
amilcarlucas
added a commit
that referenced
this pull request
Dec 27, 2025
…b.suppress, and consolidate returns - Split download logic into helper to satisfy PLR0915 - Added `expected_sha256` docstring entry for `download_and_install_on_windows` - Replace try/except pass with `contextlib.suppress(OSError)` - Mark pip install subprocess call with `# noqa: S603` - Consolidate return paths in UpdateManager._perform_download to satisfy PLR0911
amilcarlucas
added a commit
that referenced
this pull request
Dec 27, 2025
…0915) - Extract small helpers: _build_proxies, _existing_size_and_headers, _parse_total_size, _write_response - Keep external API of download_file_from_url unchanged
amilcarlucas
added a commit
that referenced
this pull request
Dec 28, 2025
…y and annotation linters - Move helper functions to module level with proper type annotations - Implement clean retry loop using helpers - Keep external API unchanged
amilcarlucas
added a commit
that referenced
this pull request
Dec 28, 2025
…mpt helper - Extracted `_attempt_download_once` with type annotations - Simplified `download_file_from_url` to reduce cyclomatic complexity - Kept behavior and tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close self.fh in __terminate_session() before clearing it so the OS file descriptor is released. This prevents PermissionError when saving complete.param on subsequent downloads. Log any close errors for diagnostics.
Closes #1151