-
Notifications
You must be signed in to change notification settings - Fork 48
Spdx #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spdx #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request focuses on improving SPDX compliance and code quality by adding REUSE ignore markers for generated files, removing obsolete CLI tests, improving type safety, and updating the REUSE linting tool.
Key changes:
- Added REUSE-IgnoreStart/End comments around SPDX headers in auto-generated file
- Removed CLI argument parser and main function tests from frontend test files
- Added type checking for connection_history to handle corrupted data gracefully
- Updated reuse-tool pre-commit hook from v5.1.1 to v6.2.0
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| update_flight_controller_ids.py | Added REUSE ignore markers around SPDX headers in generated output to prevent linting conflicts |
| tests/test_frontend_tkinter_template_overview.py | Removed test for argument_parser and corresponding imports, plus two tests for main function behavior |
| tests/test_frontend_tkinter_motor_test.py | Removed CLI-related tests and cleaned up unused imports for argument_parser and main |
| tests/test_backend_filesystem_program_settings.py | Improved comment accuracy from "for port connection string to save" to "by default" |
| ardupilot_methodic_configurator/backend_filesystem_program_settings.py | Added defensive type checking for connection_history to handle corrupted settings data |
| .pre-commit-config.yaml | Updated reuse-tool version from v5.1.1 to v6.2.0 for improved SPDX compliance checking |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 3 files ± 0 3 suites ±0 32m 11s ⏱️ -1s Results for commit 5944087. ± Comparison against base commit 6d849ca. This pull request removes 14 tests.♻️ This comment has been updated with latest results. |
No description provided.