Skip to content

Conversation

@amilcarlucas
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 8, 2026 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request focuses on improving SPDX compliance and code quality by adding REUSE ignore markers for generated files, removing obsolete CLI tests, improving type safety, and updating the REUSE linting tool.

Key changes:

  • Added REUSE-IgnoreStart/End comments around SPDX headers in auto-generated file
  • Removed CLI argument parser and main function tests from frontend test files
  • Added type checking for connection_history to handle corrupted data gracefully
  • Updated reuse-tool pre-commit hook from v5.1.1 to v6.2.0

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
update_flight_controller_ids.py Added REUSE ignore markers around SPDX headers in generated output to prevent linting conflicts
tests/test_frontend_tkinter_template_overview.py Removed test for argument_parser and corresponding imports, plus two tests for main function behavior
tests/test_frontend_tkinter_motor_test.py Removed CLI-related tests and cleaned up unused imports for argument_parser and main
tests/test_backend_filesystem_program_settings.py Improved comment accuracy from "for port connection string to save" to "by default"
ardupilot_methodic_configurator/backend_filesystem_program_settings.py Added defensive type checking for connection_history to handle corrupted settings data
.pre-commit-config.yaml Updated reuse-tool version from v5.1.1 to v6.2.0 for improved SPDX compliance checking

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10796 9962 92% 89% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
ardupilot_methodic_configurator/backend_filesystem_program_settings.py 97% 🟢
ardupilot_methodic_configurator/data_model_software_updates.py 98% 🟢
ardupilot_methodic_configurator/frontend_tkinter_template_overview.py 91% 🟢
TOTAL 95% 🟢

updated for commit: 883247b by action🐍

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Test Results

    3 files  ± 0      3 suites  ±0   32m 11s ⏱️ -1s
2 863 tests  - 14  2 856 ✅  - 14   7 💤 ±0  0 ❌ ±0 
8 589 runs   - 42  8 568 ✅  - 42  21 💤 ±0  0 ❌ ±0 

Results for commit 5944087. ± Comparison against base commit 6d849ca.

This pull request removes 14 tests.
tests.test_frontend_tkinter_motor_test.TestCommandLineWorkflow ‑ test_argument_parser_wires_common_arguments
tests.test_frontend_tkinter_motor_test.TestCommandLineWorkflow ‑ test_main_success_and_failure_paths
tests.test_frontend_tkinter_project_creator.TestArgumentParserAndMainFunction ‑ test_user_can_access_main_function_window_creation_path
tests.test_frontend_tkinter_project_creator.TestArgumentParserAndMainFunction ‑ test_user_can_parse_command_line_arguments_successfully
tests.test_frontend_tkinter_project_creator.TestMainFunctionErrorPaths ‑ test_if_name_main_calls_main_function
tests.test_frontend_tkinter_project_creator.TestMainFunctionErrorPaths ‑ test_user_sees_error_when_no_parameter_files_found_in_main
tests.test_frontend_tkinter_template_overview ‑ test_argument_parser_loglevel_options[argv0-DEBUG]
tests.test_frontend_tkinter_template_overview ‑ test_argument_parser_loglevel_options[argv1-INFO]
tests.test_frontend_tkinter_template_overview ‑ test_argument_parser_loglevel_options[argv2-WARNING]
tests.test_frontend_tkinter_template_overview ‑ test_argument_parser_loglevel_options[argv3-ERROR]
…

♻️ This comment has been updated with latest results.

@amilcarlucas amilcarlucas merged commit 57684c1 into master Jan 8, 2026
22 of 24 checks passed
@amilcarlucas amilcarlucas deleted the spdx branch January 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants