tests(tcl/tk): Use tcl/tk 9.0.3 on python 3.14 #1196
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a test failure by updating the GitHub Actions workflow to use Tcl/Tk 9.0 for Python 3.14 and 3.14t testing, while maintaining Tcl/Tk 8.6 compatibility for Python 3.9. The change addresses incompatibility issues between Python 3.14 and Tcl/Tk 8.6.14.
Changes:
- Added conditional logic to install different Tcl/Tk versions based on Python version
- Updated system dependency installation to use tcl9.0/tk9.0 packages for Python 3.14 and 3.14t
- Updated environment variable paths for TCL_LIBRARY and TK_LIBRARY to match the installed versions
| # Python 3.14 and 3.14t: use Tcl/Tk 9.0 | ||
| sudo apt-get install -y \ | ||
| python3-tk \ | ||
| scrot xdotool x11-utils gnome-screenshot \ | ||
| tcl9.0 tk9.0 libtcl9.0 libtk9.0 |
There was a problem hiding this comment.
The comment mentions "Tcl/Tk 9.0" but the PR title specifies "tcl/tk 9.0.3". The package names used (tcl9.0, tk9.0, libtcl9.0, libtk9.0) install version 9.0.x from the Ubuntu repository, which may not be specifically version 9.0.3. Consider either:
- Updating the comment to match the actual version being installed (likely 9.0.x from Ubuntu repos), or
- If version 9.0.3 is specifically required, explicitly specify the version in the apt-get install command (e.g., tcl9.0=9.0.3-*)
| # Python 3.14 and 3.14t: Tcl/Tk 9.0 paths | ||
| echo "TCL_LIBRARY=/usr/share/tcltk/tcl9.0" >> $GITHUB_ENV | ||
| echo "TK_LIBRARY=/usr/share/tcltk/tk9.0" >> $GITHUB_ENV |
There was a problem hiding this comment.
The comment mentions "Tcl/Tk 9.0" but the PR title specifies "tcl/tk 9.0.3". Consider updating this comment to clarify the actual version being used, or ensure consistency between the comment, the PR title, and the actual packages being installed.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Test Results2 914 tests 2 907 ✅ 11m 36s ⏱️ Results for commit dcf6630. ♻️ This comment has been updated with latest results. |
The python 3.14 tests stopped working with tcl/tk 8.6.14
amilcarlucas
force-pushed
the
tcl_9_in_python_3.14
branch
from
2d675e8 to
dcf6630
Compare
|
Replaced by #1206 |
The python 3.14 tests stopped working with tcl/tk 8.6.14