Try to fix #1189 #1205
Try to fix #1189 #1205
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 3 files 3 suites 33m 32s ⏱️ For more details on these failures and errors, see this check. Results for commit 056b8a4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR adds a diagnostic warning around parameter export to help investigate issue #1189 related to writing configuration files without explicit user confirmation.
Changes:
- Logs a warning immediately before exporting parameters to
.paramfiles inupdate_and_export_vehicle_params_from_fc, with a FIXME comment referencing issue #1189.
| self.merge_forced_or_derived_parameters(param_filename, self.derived_parameters, existing_fc_params) | ||
| # FIXME: maybe this writes to the filesystem without asking for user confirmation? | ||
| # see https://github.com/ArduPilot/MethodicConfigurator/issues/1189 | ||
| logging_warning("Maybe wrote to the filesystem without asking for user confirmation") |
There was a problem hiding this comment.
This newly added warning message is both vague ("Maybe wrote to the filesystem...") and not localized via _() unlike the rest of the logging in this module, which will confuse users and break internationalization conventions. Please either make the message specific and actionable (or downgrade it to a debug-level trace if it’s only for investigation), and wrap the string in _() to ensure it participates in translations, consistent with other logging_* calls in this file.
| logging_warning("Maybe wrote to the filesystem without asking for user confirmation") | |
| logging_debug(_("Exporting parameters to '%s' without explicit user confirmation"), param_filename) |
amilcarlucas
force-pushed
the
fix_1189
branch
from
3d9d436 to
0094ff2
Compare
for more information, see https://pre-commit.ci
No description provided.