Skip to content

Conversation

@amilcarlucas
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 9, 2026 22:30
@amilcarlucas amilcarlucas merged commit a264e6a into master Feb 9, 2026
26 of 27 checks passed
@amilcarlucas amilcarlucas deleted the ruff_lint branch February 9, 2026 22:36
@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11345 10335 91% 89% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 37fe323 by action🐍

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s static analysis setup by enabling additional Ruff lint rule families and bumping the Ruff pre-commit hook version, with a small cleanup to avoid new lint violations.

Changes:

  • Expanded tool.ruff.lint.select to include more lint rule families (e.g., FIX, TD, FA, additional PL* categories).
  • Updated ruff-pre-commit hook revision in .pre-commit-config.yaml.
  • Removed a commented-out FIXME line in mavftp_example.py to comply with newly enabled rules.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Enables additional Ruff linters and adds a couple of ignore entries to tune enforcement.
ardupilot_methodic_configurator/mavftp_example.py Removes a FIXME comment that would be flagged by the newly enabled FIX rules.
.pre-commit-config.yaml Bumps the Ruff pre-commit hook version to pick up newer Ruff behavior/rules.
Comments suppressed due to low confidence (1)

ardupilot_methodic_configurator/mavftp_example.py:195

  • This statement is unreachable.
    global old_mavftp_member_variable_values  # noqa: PLW0603 pylint: disable=global-statement, unreachable

"INT", # flake8-gettext
"FLY", # flynt
"I", # isort
"C90", # maccabe
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the comment: this linter is named “mccabe” (double ‘c’), not “maccabe”.

Suggested change
"C90", # maccabe
"C90", # mccabe

Copilot uses AI. Check for mistakes.
Comment on lines +259 to +260
"FA100", # Add `from __future__ import annotations` to simplify xxx
"TRY400", # Use logging.exception instead of logging.error
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRY400 is listed in lint.ignore, but the TRY (tryceratops) ruleset isn’t enabled in lint.select (it’s commented out). This ignore entry is currently a no-op and can be confusing; either enable TRY or remove TRY400 from the ignore list until it’s needed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant