-
Notifications
You must be signed in to change notification settings - Fork 35
Use uv to install pytest environment #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflow for setting up a Python environment by replacing the previous setup step with the uv tool for environment management and dependency installation.
- Replaced actions/setup-python with astral-sh/setup-uv.
- Updated dependency installation to use uv pip install.
Comments suppressed due to low confidence (2)
.github/workflows/pytest.yml:52
- Confirm that removing the explicit pip version installation is intentional, as it may impact environment consistency if pip updates lead to compatibility issues.
uv pip install .[dev]
.github/workflows/pytest.yml:48
- [nitpick] Double-check that the 'activate-environment: true' flag is still required and correctly configured according to the latest uv documentation.
activate-environment: true
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 896277b. ♻️ This comment has been updated with latest results. |
f1910db
to
b2c7135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the GitHub Actions workflow for Python environment setup by replacing the previous setup step with the uv tool.
- Replaces actions/setup-python with astral-sh/setup-uv including the addition of the activate-environment option.
- Consolidates dependency installation commands to use the uv pip command.
b1ac2e8
to
4718bf6
Compare
7146684
to
83516df
Compare
cb9ccfc
to
a8fa708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
pip works fine here and all the tests do pass. But I wanted to speed it up. |
58b0bb8
to
fd513d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the existing actions/setup-python
step in the pytest workflow with astral-sh/setup-uv
to streamline environment management and aligns dependency installation with the uv
tool.
- Swapped out
actions/setup-python
forastral-sh/setup-uv
and enabledactivate-environment
- Changed dependency installation from plain
pip install
touv pip install
Comments suppressed due to low confidence (3)
.github/workflows/pytest.yml:45
- Pinning to a specific commit can make upgrades harder and obscure version history. Consider using the official semver tag (e.g.,
v6.2.1
) instead of a raw SHA for clarity and easier maintenance.
uses: astral-sh/setup-uv@a02a550bdd3185dba2ebb6aa98d77047ce54ad21 # v6.2.1
.github/workflows/pytest.yml:52
- [nitpick] This note is a bit vague—linking to an issue or briefly explaining the underlying failure would help future maintainers understand why the workaround is necessary.
# pip causes unit tests to crash when combined with uv, so avoid installing it
.github/workflows/pytest.yml:53
- [nitpick] The commented-out install command adds noise to the workflow file. If it’s no longer needed, consider removing it to keep the CI config clean.
# uv pip install 'pip==25.1.1'
f6a0cc3
to
6673b1e
Compare
6673b1e
to
eb3cb06
Compare
eb3cb06
to
9429341
Compare
uv v0.8... was released in the past 24 hours. |
I just updated it to 6.4.1 |
095ed55
to
a55c3d0
Compare
I hope to have fixed this with commit 9469e1b |
6cac765
to
5014589
Compare
5014589
to
67bfecc
Compare
for more information, see https://pre-commit.ci
This pull request updates the workflow configuration in
.github/workflows/pytest.yml
to integrate with theuv
tool for managing Python environments, replacing the previousactions/setup-python
step. This change simplifies environment setup and dependency installation.Workflow updates for Python environment setup:
actions/setup-python
withastral-sh/setup-uv
to manage Python environments, enabling theactivate-environment
option for seamless integration.uv pip install
instead of directly invokingpip
, aligning with theuv
tool's workflow.