Fix pre-commit failure with noqa: ANN401 #691
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.astral.sh/ruff/rules/any-type Also, why not make this change? ```diff def is_empty(val: Any) -> bool: - return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) + return not val ```
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pre-commit linting failure by adding a noqa: ANN401 comment to suppress ruff's warning about using Any type annotation. The change addresses a specific linting rule that flags the use of Any type hints as potentially problematic.
Key Changes
- Added
noqa: ANN401comment to suppress ruff's any-type warning for theis_emptyfunction parameter
| @@ -368,7 +368,7 @@ def wipe_component_info(self) -> None: | |||
| }, | |||
| } | |||
|
|
|||
| def is_empty(val: Any) -> bool: | |||
| def is_empty(val: Any) -> bool: # noqa: ANN401 | |||
| return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) | |||
There was a problem hiding this comment.
Consider replacing the complex logic with return not val as suggested in the PR description. The current implementation val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) is redundant since Python's truthiness evaluation already handles these cases correctly, and the dict check is unnecessary as empty dicts are falsy.
Suggested change
| return val in (None, "", 0, 0.0, {}) or (isinstance(val, dict) and not val) | |
| return not val |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff/rules/any-type --> https://results.pre-commit.ci/repo/github/778163871
Also, why not make this change?