Update .gitmodules - #56
Conversation
moved to firewall friend URLs; removed "git:"
|
looks fine to me, @lucasdemarchi ? |
|
LGTM |
|
humn... I think the reason to use git:// protocol is that it's read-only, so one would avoid accidental pushes to a submodule. I'm not against changing it though. |
|
wouldn't you need to be a maintainer to be able to push? On Tue, Jun 21, 2016 at 5:06 PM Lucas De Marchi notifications@github.com
|
|
git doesn't have fine grained permissions so there are lots of people with "Maintainer" rights who administer issues, pull request comments, labels etc but don't actually ever "push" into master. That's where the git:// comes in as it allows all those other functions but as Lucas has said its read only to avoid accidental pushes. |
moved to firewall friendly URLs; removed "git:"