Skip to content

Conversation

@peterbarker
Copy link

this information has been moved to the enumeration definition

this is no compiler output change for ArduPilot.

This is a stricter version of #385 which doesn't contain stray changes to the XML.

I've verified that all of the enumerations referenced on these lines are marked as bitmasks.

I've looked at the difference in generated .h and there's no difference to speak of (just the XML hashes)

pymavlink generation also shows not output change:

pbarker@crun:~/rc/pymavlink(master)$ diff -u /tmp/x.py /tmp/y.py 
--- /tmp/x.py	2025-12-08 17:25:29.533130958 +1100
+++ /tmp/y.py	2025-12-08 17:21:34.961428630 +1100
@@ -16,7 +16,7 @@
 from typing import Any, Callable, Dict, Iterable, List, Mapping, Optional, Sequence, Tuple, Type, Union
 
 WIRE_PROTOCOL_VERSION = "1.0"
-DIALECT = "x"
+DIALECT = "y"
 
 PROTOCOL_MARKER_V1 = 0xFE
 PROTOCOL_MARKER_V2 = 0xFD
pbarker@crun:~/rc/pymavlink(master)$ 

this information has been moved to the enumeration definition
@peterbarker peterbarker merged commit 6d663dd into ArduPilot:master Dec 15, 2025
12 checks passed
@peterbarker peterbarker deleted the pr/remove-bitmask-things branch December 29, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants