PoC: Move docstring assert to the DSL state machine #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
force-pushed
the
clinic/docstring-assert-summary-separator
branch
from
11b0438 to
04e18a5
Compare
|
An alternative to this could be to compute the correct line number from within format_docstring(). |
OTOH, if we move the docstring formatting to the render step, it might not be that easy to get the correct line number anymore; perhaps the parsing state machine is the best place for it. |
erlend-aasland
force-pushed
the
clinic/docstring-assert-summary-separator
branch
from
04e18a5 to
2c81ba9
Compare
erlend-aasland
force-pushed
the
clinic/docstring-assert-summary-separator
branch
from
2c81ba9 to
96767a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.