Argument Clinic: Remove METHOD_INIT and METHOD_NEW function kinds

[erlend-aasland]

No description provided.

[AlexWaygood]

This doesn't need to be a cached_property anymore; we can just assign it eagerly in __post_init__:

Suggested change

	@functools.cached_property
	def new_or_init(self) -> bool:
	return self.name in ("__new__", "__init__")
	self.new_or_init = self.name in ("__new__", "__init__")

[erlend-aasland]

Ok, that's fine. But what do you think of this refactor?

[erlend-aasland]

Sorry, I did not mean to be dismissive! Thanks for the suggestion :)

[AlexWaygood]

Sorry, you're right; the overall concept is more important!

I think it looks good. Conceptually, I think these aren't really distinct categories of methods; they're subcategories of (respectively) CALLABLE and CLASS_METHOD. So we're simplifying some code while also making it conceptually cleaner, which is nice.

The benefit doesn't seem huge to me right now, but I'll trust you when you say that this clears the way for further refactorings :)

[erlend-aasland]

I'll try to formulate my motivation for doing this. I just need to find time to jot it down :)

[erlend-aasland]

Suggested change

	if f.kind in (STATIC_METHOD, CLASS_METHOD) or f.name == "__init__":
	if f.kind in (STATIC_METHOD, CLASS_METHOD) or f.new_or_init:

[erlend-aasland]

Reads slightly nicer.

[erlend-aasland]

Suggested change

	if f.kind is CALLABLE or f.name == "__init__":
	if f.kind is CALLABLE:

[AlexWaygood]

I think you should assign three attributes in __post_init__:

class Function:
    # <-- snip -->
    def __post_init__(self) -> None:
        # <-- snip -->
        self.init_method = self.name == "__init__"
        self.new_method = self.name == "__new__"
        self.new_or_init = self.init_method or self.new_method

Then you wouldn't have to have so many "magic strings" everywhere -- everywhere you're currently doing if f.name == "__init__", you can just do if f.init_method

[erlend-aasland]

I think you should assign three attributes in __post_init__:

class Function:
    # <-- snip -->
    def __post_init__(self) -> None:
        # <-- snip -->
        self.init_method = self.name == "__init__"
        self.new_method = self.name == "__new__"
        self.new_or_init = self.init_method or self.new_method

Then you wouldn't have to have so many "magic strings" everywhere -- everywhere you're currently doing if f.name == "__init__", you can just do if f.init_method

Yeah, that's neat. I thought of doing something like that; I'm not a fan of the name == "__init__" comparisons either.