Skip to content

Bump vertx.core.version from 4.5.14 to 5.0.1 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump vertx.core.version from 4.5.14 to 5.0.1 #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10687ec
Bump vertx.core.version from 4.5.14 to 5.0.1
dependabot[bot] Jul 21, 2025
e6abbaa
working tests
BrandonArp Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
<snappy.version>1.1.10.8</snappy.version>
<spotbugs.annotations.version>4.9.3</spotbugs.annotations.version>
<typesafe.config.version>1.4.4</typesafe.config.version>
<vertx.core.version>4.5.14</vertx.core.version>
<vertx.core.version>5.0.1</vertx.core.version>

<!--Test dependency versions-->
<commons.math3.version>3.6.1</commons.math3.version>
Expand Down Expand Up @@ -535,6 +535,19 @@
</plugins>
</build>

<dependencyManagement>
<dependencies>
<!-- Force Netty version to be compatible with Vert.x 5.x -->
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>4.2.2.Final</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<!-- Logging -->
<dependency>
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/arpnetworking/tsdcore/sinks/VertxSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,8 @@ private void connectToServer() {
.addData("port", _serverPort)
.log();
_lastConnectionAttempt = currentTime;
_client.connect(
_serverPort,
resolvedHostname,
new ConnectionHandler(resolvedHostname));
_client.connect(_serverPort, resolvedHostname)
.onComplete(new ConnectionHandler(resolvedHostname));
}

private Handler<Void> createSocketCloseHandler(final NetSocket socket) {
Expand Down