enable compression in http post sink #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonArp
force-pushed
the
sink_compression
branch
from
a68a11f to
5fabb24
Compare
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables optional GZIP compression for HTTP POST sinks. The changes include adding a new netty-codec-http dependency, introducing an _enableCompression flag in HttpPostSink, and implementing the compression logic. The RequestEntry model is updated to track original and encoded body sizes, and these new metrics are recorded in HttpSinkActor. The createRequest method in all HttpPostSink subclasses has been updated to return a RequestInfo object containing the request and body sizes. My review focuses on improving code robustness and fixing a contradiction in the new configuration.
src/main/java/com/arpnetworking/tsdcore/model/RequestEntry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.