Skip to content

Fix failing Dependabot update tests #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
+11 −13
Merged

Fix failing Dependabot update tests #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d68dc4e
Bump io.netty:netty-codec-http from 4.2.6.Final to 4.2.7.Final
dependabot[bot] Oct 24, 2025
cc989a8
Fix Netty 4.2.7 compatibility by using string literals for HTTP headers
claude Nov 7, 2025
2663eb5
Add Netty BOM to dependency management to resolve version conflicts
claude Nov 7, 2025
e43c693
Remove unused netty-codec-http dependency
claude Nov 7, 2025
eb284bf
Consolidate Netty version properties to use netty.version
claude Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,8 @@
<metrics.http.extra.version>0.14.1</metrics.http.extra.version>
<metrics.aggregator.protocol.version>1.3.1</metrics.aggregator.protocol.version>
<mockito.version>5.20.0</mockito.version>
<netty.version>4.0.56.Final</netty.version>
<netty.version>4.2.7.Final</netty.version>
<netty.all.version>4.0.21.Final</netty.all.version>
<netty.codec.http.version>4.2.6.Final</netty.codec.http.version>
<ning.http.client.version>1.9.31</ning.http.client.version>
<oval.version>3.2.1</oval.version>
<play.ws.version>3.0.9</play.ws.version>
Expand Down Expand Up @@ -860,11 +859,6 @@
<artifactId>async-http-client</artifactId>
<version>${asynchttpclient.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http</artifactId>
<version>${netty.codec.http.version}</version>
</dependency>
<dependency>
<groupId>org.playframework</groupId>
<artifactId>play-ahc-ws-standalone_${scala.version}</artifactId>
Expand Down Expand Up @@ -976,6 +970,13 @@
<scope>import</scope>
<type>pom</type>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${netty.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
</dependencies>
</dependencyManagement>
<profiles>
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/arpnetworking/tsdcore/sinks/HttpPostSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
import com.fasterxml.jackson.annotation.JacksonInject;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Lists;
import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpHeaderValues;
import net.sf.oval.Validator;
import net.sf.oval.constraint.CheckWith;
import net.sf.oval.constraint.CheckWithCheck;
Expand Down Expand Up @@ -127,12 +125,12 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s

final RequestBuilder requestBuilder = new RequestBuilder()
.setUri(getAysncHttpClientUri())
.setHeader(HttpHeaderNames.CONTENT_TYPE, MediaTypes.APPLICATION_JSON.toString())
.setHeader("Content-Type", MediaTypes.APPLICATION_JSON.toString())
.setBody(bodyData)
.setMethod(HttpConstants.Methods.POST);

if (_enableCompression) {
requestBuilder.setHeader(HttpHeaderNames.CONTENT_ENCODING, HttpHeaderValues.GZIP);
requestBuilder.setHeader("Content-Encoding", "gzip");
}

return new RequestInfo(requestBuilder.build(), serializedData.length, bodyData.length);
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/arpnetworking/tsdcore/sinks/KairosDbSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import io.netty.handler.codec.http.HttpHeaderNames;
import it.unimi.dsi.fastutil.doubles.Double2LongMap;
import net.sf.oval.constraint.Min;
import net.sf.oval.constraint.NotNull;
Expand Down Expand Up @@ -177,7 +176,7 @@ protected RequestInfo createRequest(final AsyncHttpClient client, final byte[] s

final RequestBuilder requestBuilder = new RequestBuilder()
.setUri(getAysncHttpClientUri())
.setHeader(HttpHeaderNames.CONTENT_TYPE, "application/gzip")
.setHeader("Content-Type", "application/gzip")
.setBody(bodyData)
.setMethod(HttpConstants.Methods.POST);

Expand Down