VAST-84: Fix race condition in async initialization#84
Merged
privaloops merged 1 commit intodevelopfrom Feb 24, 2026
Merged
Conversation
…-84) - Remove const self = this pattern that was a workaround for Turbopack (VAST-72) - Replace async IIFE with .then() to preserve lexical this - Call addEventsListeners() before handleVAST() to prevent race condition where readyforpreroll could fire before listeners were attached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const self = thispattern (workaround for Turbopack bundling issue, VAST-72).then()to preserve lexicalthisin class contextreadyforprerollcould fire before listeners were attachedContext
Under Turbopack,
thiswas lost inside the async IIFE (VAST-72). Theconst self = thisworkaround fixed that but masked a deeper issue:addEventsListeners()was called after the async fetch, meaning events emitted during the fetch were missed (VAST-84). This was also related to PLAYER-3648 where plugin re-instantiation caused tracking failures.Test plan