[DON'T MERGE] Add per session peak volume#92
Open
Cheerpipe wants to merge 7 commits intoArtemis-RGB:masterfrom
Open
[DON'T MERGE] Add per session peak volume#92Cheerpipe wants to merge 7 commits intoArtemis-RGB:masterfrom
Cheerpipe wants to merge 7 commits intoArtemis-RGB:masterfrom
Conversation
Thanks to Darth Affe for their span thing sorcery
Cheerpipe
changed the title
Cheerpipe
changed the title
Cheerpipe
changed the title
Member
|
Hey Pipe, would you like to finish this PR anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a collection of applications and their audio session real time peak volume.
To make this works, i had to create a settings that holds used data sessions to create (or re-create an empty/volume 0 session datamodel) them at plugin startup otherwise conditions using these dynamic datamodels will fail because these session datamodels don't exists at the moment Artemis is loaded (Don't know if this is an Artemis bug or the intended behavior).