Open
Conversation
Since the values stored in `Bias` and `ActiveTimeBias` are unsigned 32-bit integers, and the code expects a negative integer when the UTC offset is positive, the calculation is incorrect because it doesn't convert the unsigned integer to the correct minutes offset. The code should handle this by checking if the MSB is 1 and using `~(offset) + 1` in that case. The attached image shows what happens in the UK, which is currently UTC+1. The same problem happens for all UTC+n countries, making this issue widespread for users in Europe and Asia. Also simplified the detection of date change crossover using `%A_NowUTC%` so it is standardised for all users. `changeDate` variable remains in the code only because it's used in the status message, can be removed to further simplify.
OzoTheGreat
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the values stored in
BiasandActiveTimeBiasare unsigned 32-bit integers, and the code expects a negative integer when the UTC offset is positive, the calculation is incorrect because it doesn't convert the unsigned integer to the correct minutes offset. The code should handle this by checking if the MSB is 1 and using~(offset) + 1in that case. The attached image shows what happens in the UK, which is currently UTC+1. The same problem happens for all UTC+n countries, making this issue widespread for users in Europe and Asia.Also simplified the detection of date change crossover using
%A_NowUTC%so it is standardised for all users.changeDatevariable remains in the code only because it's used in the status message, can be removed to further simplify.