usb: skip usb_i2c_restore_irqs on models where i2c is not present#508
Merged
jannau merged 1 commit intoAsahiLinux:mainfrom Oct 25, 2025
Merged
usb: skip usb_i2c_restore_irqs on models where i2c is not present#508jannau merged 1 commit intoAsahiLinux:mainfrom
jannau merged 1 commit intoAsahiLinux:mainfrom
Conversation
yuyuyureka
force-pushed
the
t8132-usb-i2c
branch
from
3fdd051 to
35d055c
Compare
jannau
reviewed
Oct 21, 2025
yuyuyureka
force-pushed
the
t8132-usb-i2c
branch
from
35d055c to
b6a02e3
Compare
yuyuyureka
changed the title
Signed-off-by: Yureka <yureka@cyberchaos.dev>
yuyuyureka
force-pushed
the
t8132-usb-i2c
branch
from
b6a02e3 to
46a1db5
Compare
jannau
approved these changes
Oct 22, 2025
Member
jannau
left a comment
jannau
left a comment
There was a problem hiding this comment.
Comments are random thoughts while looking at the change, no need to change anything.
|
|
||
| /* | ||
| * M3 models do not use i2c, but instead SPMI with a new controller. | ||
| * M3/M4 models do not use i2c, but instead SPMI with a new controller. |
| * Do not try to restore irqs on M3/M4 which don't use i2c | ||
| */ | ||
| if (adt_path_offset(adt, "/arm-io/nub-spmi-a0/hpm0") > 0) | ||
| return; |
Member
There was a problem hiding this comment.
This starts growing to a level where we probably should start thinking of adding some sort of device abstraction like Sven did with CPU initialization and I started for display initialization.
Contributor
Author
There was a problem hiding this comment.
Shouldn't it be possible to iterate the i2c and spmi nodes in the ADT and find the ones which have the usbc,manager, and initialize those without adding specialized code for each series/model?
Member
There was a problem hiding this comment.
that would be a possibility as well
mildsunrise
added a commit
to mildsunrise/m1n1
that referenced
this pull request
Nov 28, 2025
revert AsahiLinux#365 (+ part of AsahiLinux#508) and instead use the appropriate transport as necessary
mildsunrise
added a commit
to mildsunrise/m1n1
that referenced
this pull request
Nov 30, 2025
revert AsahiLinux#365 (+ part of AsahiLinux#508) and instead use the appropriate transport as necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a crash while chainloading