Merged
Conversation
asdfugil
suggested changes
Dec 7, 2025
svenpeter42
approved these changes
Dec 15, 2025
0x40 from "dart-options" does not identify the layout. T8122's dart-pmp has this set but uses in macOS 26.0.1 the 52 byte descriptor layout. Since this is not used in python code just simplify the parsing so that it does not fall over. Signed-off-by: Janne Grunau <j@jannau.net>
T8122's dart-pmp dapf-instance-0 has no fixed layout. At least up to macOS 15.1 it uses a 56 byte layout (DAPFT8110B in m1n1/adt.py) and macOS 26.0.1 switches to the standard 52 byte layout. The flag from "dart-options" used in m1n1/adt.py does not distinguish these two variants. Support both variants and prefer the original 52 byte variant. The array length does not identify the variant for multiples of 728. This actually occurs on t8122's dart-aop.dapf-instance-0 and the 52 byte variant is correct in that case. Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: Janne Grunau <j@jannau.net>
jannau
force-pushed
the
t8122_bringup
branch
2 times, most recently
from
127ea03 to
346bb7f
Compare
Add register definitions for AGTCNTRDIR_EL1 and AGTCNTRDIR_EL12 and activate counter scaling to 1GHz as per ARMv8.6 requirements. Do not enable trapping for EL0 accesses via BIT(0) of AGTCNTRDIR_*. Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: Janne Grunau <j@jannau.net>
svenpeter42
approved these changes
Feb 7, 2026
asdfugil
approved these changes
Feb 7, 2026
Contributor
|
Looks good, with the AGTCNTRDIR registers set to zero XNU won't boot correctly but that's the job of the HV code and a story for another time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds chickens, midr and bringup UART address and refactors dapf parsing