Store profile keys for group v2 requesting members - #2031
Merged
AsamK merged 1 commit intoApr 27, 2026
Merged
Conversation
When filling or updating a V2 group, profile keys were copied from DecryptedGroup.members into the local profile store but not from requestingMembers. Admins who never had a prior session with a user in the join queue then lacked profile keys and could not decrypt profiles (e.g. for listContacts). Also process DecryptedRequestingMember entries the same way as full members, using DecryptedMember / DecryptedRequestingMember types so the lib module does not require a direct protobuf dependency. Made-with: Cursor
AsamK
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a gap where storeProfileKeysFromMembers only ingested profile keys from DecryptedGroup.members, not from
equestingMembers (as DecryptedRequestingMember).
Symptom: After a group refresh, an admin (or signal-cli) that had not previously exchanged with someone in the join queue could not decrypt their profile, so e.g. \listContacts\ / UIs showed empty names for those requesters, while the official clients could still show them.
Change: Reuse the same store-if-missing logic for each requesting member, using the existing proto types so \libsignal-cli\ does not need a direct \com.google.protobuf\ compile dependency in \GroupHelper.
Testing: We run this in a downstream Docker image; behavior verified against a real group with a pending join queue.
cc @AsamK
Made with Cursor