Skip to content

Fix party disbanding logic when last player leaves #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimtyG wants to merge 1 commit into from
Closed

Fix party disbanding logic when last player leaves #2482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions Intersect.Server.Core/Entities/Player.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5265,19 +5265,30 @@ public void LeaveParty()

string partyMessage = currentParty.Count > 1
? Strings.Parties.MemberLeft.ToString(Name)
: Strings.Parties.Disbanded;
: Strings.Parties.Disbanded.ToString();

// Update all members of the party with the new list
foreach (var partyMember in currentParty)
{
partyMember.Party = currentParty.ToList();
PacketSender.SendParty(partyMember);
PacketSender.SendChatMsg(
partyMember,
partyMessage,
ChatMessageType.Party,
CustomColors.Alerts.Error
);
if (partyMessage != Strings.Parties.Disbanded.ToString())
{
PacketSender.SendChatMsg(
partyMember,
partyMessage,
ChatMessageType.Party,
CustomColors.Alerts.Error
);
}
}
// If theres only one player left, lets disband the party
if (currentParty.Count == 1)
{
var remainingMember = currentParty[0];
remainingMember.Party.Clear();
PacketSender.SendParty(remainingMember);
PacketSender.SendChatMsg(remainingMember, Strings.Parties.Disbanded, ChatMessageType.Party, CustomColors.Alerts.Error);
}

Party = new List<Player>();
Expand Down
Loading