Skip to content

fix: update editor dictionary attribute type name and strings dictionary type #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandinocoder merged 1 commit into from
Feb 17, 2025
Merged

fix: update editor dictionary attribute type name and strings dictionary type #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Framework/Intersect.Framework.Core/GameObjects/Maps/MapAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public partial class MapWarpAttribute : MapAttribute
public bool ChangeInstance { get; set; } = false;

[EditorLabel("Warping", "InstanceType")]
[EditorDictionary("Mapping", "InstanceTypes")]
[EditorDictionary("MapInstance", "InstanceTypes")]
public MapInstanceType InstanceType { get; set; } = MapInstanceType.Overworld;

[EditorLabel("Attributes", "WarpSound")]
Expand Down
2 changes: 1 addition & 1 deletion Intersect.Editor/Localization/Strings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4209,7 +4209,7 @@ public partial struct MapGrid
public partial struct MapInstance
{
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
public static Dictionary<MapInstanceType, LocalizedString> InstanceTypes = new Dictionary<MapInstanceType, LocalizedString>
public static LocaleDictionary<MapInstanceType, LocalizedString> InstanceTypes = new LocaleDictionary<MapInstanceType, LocalizedString>
{
{MapInstanceType.Overworld, @"Overworld" },
{MapInstanceType.Personal, @"Personal" },
Expand Down
Loading