Escape menu window#2590
Conversation
|
Fixes issue #2546 |
pandinocoder
left a comment
pandinocoder
left a comment
There was a problem hiding this comment.
Shouldn't the original EscapeMenu class be deleted in this PR too?
| _charselect.IsDisabled = true; | ||
| } | ||
|
|
||
| _versionPanel = new VersionPanel(canvas, name: nameof(_versionPanel)); |
There was a problem hiding this comment.
Is the version panel showing up underneath the modal?
There was a problem hiding this comment.
I'll look into this. The only escapemenu had it float at the very bottom of the screen but the window isn't large enough with this version. I'll likely create an extra imagepanel and add it as a child of that.
There was a problem hiding this comment.
The version panel needs to be a child of the modal in this case, rather than another ImagePanel.
| private readonly Button _settings; | ||
| private readonly Button _charselect; | ||
| private readonly Button _logout; | ||
| private readonly Button _exitdesktop; | ||
| private readonly Button _closemenu; |
There was a problem hiding this comment.
Can you make the names be camel-case and more thorough? e.g. _returnToCharacterSelectButton
There was a problem hiding this comment.
These are tied to the UI files.
I can, but then I have to hardcode the string values.
There was a problem hiding this comment.
I realize they're tied to the UI files, but I'm ok with invalidating existing stuff (especially since the entire UI system needs to be replaced anyway).
|
|
||
| public EscapeMenuWindow(Canvas canvas, Func<SettingsWindow> settingsWindowProvider) | ||
| : base(canvas, Strings.EscapeMenu.Title, false, | ||
| $"{nameof(EscapeMenuWindow)}_{(ClientContext.IsSinglePlayer ? "singleplayer" : "online")}") |
There was a problem hiding this comment.
Good catch, I didn't even think about this having two separate layouts
With accompanied Designer file Signed-off-by: Derek Gooding <djgooding@live.com>
pandinocoder
force-pushed
the
Escape-Menu-Window
branch
from
b5db27f to
0b01984
Compare
2 participants
3rd times the charm.
Create a new Escape Menu window using the designer pattern. Call it instead of the old version.