Global dark/light theme support using ThemeProvider & AppShell#50
Global dark/light theme support using ThemeProvider & AppShell#50ashtag3696 wants to merge 3 commits intoAshrockzzz2003:v2from
Conversation
|
Hey @ashtag3696! Thank you for opening a pull request. Make sure to tag the maintainers and link the issue you are solving in your pull-request description if you have not already and they'll review as soon as possible. |
|
Share a Screen recording? |
|
Actually I can't able to submit the screen recording today as I'm in travel. Also when I tried to launch with backend it asks for Database. |
Yeah |
|
I'll try to test it then |
|
I'll share the Screen recording within 2 hrs bro |
|
Uploading Screen Recording 2026-01-09 at 7.02.15 PM.mov… |
Sorry for the Delay bro, my network was bad during travel. |
demo.mp4demo.mp4… |
|
The visibility of text/design in dark mode is not there? Fix it ... Feels like a 100% vibe coded pr |
|
Hey bro @Ashrockzzz2003, |
|
Also I wanted to ask you bro. These websites would take months maybe a year just by HTML, CSS, and js. May I know How you guys have done this. It was so difficult to read at first for me. |
Ashrockzzz2003
left a comment
There was a problem hiding this comment.
Before
Screen.Recording.2026-01-11.at.15.57.09.mov
After
Screen.Recording.2026-01-11.at.15.55.09.mov
@ashtag3696 do you notice the extra scroll your change has added? Fix it.
|
Your changes still feel 100% AI driven to me |
|
For trying |
|
/bounty 35 @ashtag3696 |
|
Another day, another coin. Way to get that bounty @ashtag3696 you glorious keyboard-tapping, coffee-sipping, vibe-coding witcher! |
|
@Ashrockzzz2003 I've made those changes you've asked for globally for 3 pages. |
|
At first I thought it was like that from the very beginning, then I found out it was due to recent architecture change that led to this. Thanks for pointing it out! |
|
Architecture change?? |
Yes, this change was done at the first commit itself. The Appshell acts as structural backbone, hosts Global UI(Navbar and Theme). That's why it took me so long to find out why the themes were not working and it took me 3 days to fix it. And that's also the reason why other problems have arise. I wished to change the Navbar according to pages but it was taking too long main objective. So I've avoided for that now. |
Summary
Why?
Result =>
Limitations !
Tested Pages