feat: dAppStaking max tier thresholds #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipapandinas
added
shiden
Dinonard
reviewed
Apr 24, 2025
Contributor
Dinonard
left a comment
Dinonard
left a comment
There was a problem hiding this comment.
Looks good, I just have two requests:
- remove
Optionfrom the config - for migration, just specify the new max values, since you're not re-defining percentage nor minimum required percentage
Dinonard
reviewed
Apr 25, 2025
Contributor
Dinonard
left a comment
Dinonard
left a comment
There was a problem hiding this comment.
Please update the is_valid check and let's merge it!
runtime/shibuya/src/lib.rs
Outdated
| required_percentage: Perbill::from_parts(1_400), // 0.00014% | ||
| }, | ||
| ]; | ||
| pub const MaxPercentages: [Option<Perbill>; 4] = [None, None, None, None]; |
Contributor
There was a problem hiding this comment.
Might be good to use Some values for Shibuya, just for the sake of the test.
Contributor
Author
There was a problem hiding this comment.
Good idea, I suggest:
pub const MaxPercentages: [Option<Perbill>; 4] = [
Some(Perbill::from_parts(30_000)), // 0.0030%
Some(Perbill::from_parts(20_000)), // 0.0020%
Some(Perbill::from_parts(10_000)), // 0.0010%
None
];
Contributor
There was a problem hiding this comment.
If it works, sure.
I don't know what the min values on Shibuya are.
Contributor
Author
There was a problem hiding this comment.
[0.0017%, 0.0010%, 0.00034%]
This was referenced Apr 25, 2025
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #1458
Maximum percentages are derived from an Astar token price of $0.05 (base values from dAppStaking v3 launch).
The
maximum_possible_percentagevalue is optional. If is not specified, the default value used is 100% which reflects the entire total supply.Check list