Migration of the documentation to a major version#754
Conversation
| - name: Enable Corepack | ||
| run: corepack enable | ||
| shell: bash | ||
|
|
||
| - name: Prepare Yarn | ||
| run: corepack prepare yarn@4.9.2 --activate | ||
| shell: bash |
There was a problem hiding this comment.
It seems like these lines need to be running before setup-node. If they fail to run due to node not being installed, maybe do setup-node twice with the first one not doing the cache. Still, I feel like there's a better way to do this overall
There was a problem hiding this comment.
@JGJP Thank you for your comment. In that case, based on the context you provided, I believe running setup-node twice will be the most effective and clean solution for now. The implementation would look like this:
name: Setup Workspace
description: Setup Node.js, Yarn v4 with Corepack, and install dependencies
inputs:
build:
description: 'Whether to run `yarn build` after install'
required: false
default: 'false'
runs:
using: composite
steps:
# Step 1: Setup Node.js without Yarn cache (just to activate Corepack/Yarn)
- name: Setup Node.js (no cache)
uses: actions/setup-node@v3
with:
node-version: 22.x
cache: false
- name: Enable Corepack
run: corepack enable
shell: bash
- name: Prepare Yarn 4.9.2
run: corepack prepare yarn@4.9.2 --activate
shell: bash
# Step 2: Setup Node.js again — now with Yarn cache enabled
- name: Setup Node.js (with Yarn cache)
uses: actions/setup-node@v3
with:
node-version: 22.x
cache: yarn
- name: Install dependencies with Yarn
run: yarn install --immutable
shell: bash
- name: Build project (optional)
if: inputs.build == 'true'
run: yarn build
shell: bash@JGJP what do you think?
There was a problem hiding this comment.
Looks good, let's try it and see if the build runs
There was a problem hiding this comment.
Looks like it's building, there's some error about Buffer but seems unrelated
There was a problem hiding this comment.
Yeah, it worked!
There was a problem hiding this comment.
You might be able to get away with removing the yarn preparation step
|
Visit the preview URL for this PR (updated for commit f6222b5): https://astar-docs--pr754-feat-juminstock-migr-exvgwpit.web.app (expires Tue, 22 Jul 2025 03:20:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
|
@JGJP I think the implementation it's ready. The buffer error is related to image-size library, but works on the documentation already. Could you review the PR now, please? |
|
@Juminstock could you add me to the repo? I'm not able to approve |
andabak
left a comment
There was a problem hiding this comment.
Approved but noticing the same issue in logs as already mentioned in discussion.
I run locally and it renders docs so I guess it's acceptable to merge and then work on solving the issue with less moving parts.
TypeError: The "buffer" argument must be an instance of Buffer, TypedArray, or DataView. Received an instance of ArrayBuffer
This PR implements the following detailed changes:
4.9.2.22.17.0or a similar or higher version.3.8.1.docusaurus.config.jsto its TypeScript versionsidebars.jsto its TypeScript versionFinally, resolve occurrences of broken links, duplicated links, or links with no clear destination; improve the descriptions of the different documentation sections; and enhance the footer and parts of the Home page.