fix: do not remove supportedVersion key from pallet-xcm
#122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
supportedVersionstorage from pallet-xcmWhy?
With the new XCMv5, the deprecated XCMv2 has been completely removed. Hence any conversion to XCM v2 will result in error.
Previously, to speed-up things we removed the all the keys related to version notification from pallet-xcm, this included the
supportedVersionwhich stored remote locations latest supported xcm version. Hence when sending xcm in the absence ofsupportedVersionthe pallet-xcm convert the outgoing xcm to version stored inSafeXcmVersion.The
SafeXcmVersionis currently set to 2 in all our runtimes, and V2 has been completely removed so this conversion will fail now and thus XCM message couldn't being send