Skip to content

Conversation

@ashutoshvarma
Copy link
Contributor

Summary

  • Update the snapshots
  • Keep the supportedVersion storage from pallet-xcm

Why?

With the new XCMv5, the deprecated XCMv2 has been completely removed. Hence any conversion to XCM v2 will result in error.

Previously, to speed-up things we removed the all the keys related to version notification from pallet-xcm, this included the supportedVersion which stored remote locations latest supported xcm version. Hence when sending xcm in the absence of supportedVersion the pallet-xcm convert the outgoing xcm to version stored in SafeXcmVersion.

The SafeXcmVersion is currently set to 2 in all our runtimes, and V2 has been completely removed so this conversion will fail now and thus XCM message couldn't being send

@ashutoshvarma ashutoshvarma requested a review from ermalkaleci May 13, 2025 05:33
@ashutoshvarma
Copy link
Contributor Author

ashutoshvarma commented May 13, 2025

In the snapshots, the messageQueue events have different values with new uplift runtime the xcm weights have become slightly more.

- Expected
+ Received

@@ -21,12 +21,12 @@
      "data": {
        "id": "(hash)",
        "origin": "Parent",
        "success": true,
        "weightUsed": {
-         "proofSize": "(rounded 9400)",
+         "proofSize": "(rounded 9300)",
-         "refTime": "(rounded 900000000)",
+         "refTime": "(rounded 890000000)",
        },
      },
      "method": "Processed",
      "section": "messageQueue",
    },

Redacting the the weights to 8 precision would be too much

Copy link
Contributor

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We will need to ignore refTime until upgrade is finished, then we can revert it. It can be done on another PR

@ashutoshvarma ashutoshvarma merged commit a6296b8 into master May 13, 2025
1 check failed
@ashutoshvarma ashutoshvarma deleted the fix/xcm-tests branch May 13, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants