Skip to content

Conversation

@hugobuddel
Copy link
Contributor

I'll just merge this to get AstarVienna/ScopeSim_Data#20 working.

This wasn't checked earlier because locally I had the files cached, and the webtests do not run on the CI.

The deprecated functionality should be tested as long as it is in the codebase, so ignoring it is fine.

However, we are actually actively using the deprecated functionality, which is a bit weird.

@hugobuddel hugobuddel requested a review from teutoburg November 19, 2024 07:37
@hugobuddel hugobuddel merged commit 2ac4561 into main Nov 19, 2024
@hugobuddel hugobuddel deleted the hb/ignoreourowndeprecations branch November 19, 2024 07:38
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (bb866cf) to head (0108fb4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   56.60%   56.60%           
=======================================
  Files           8        8           
  Lines         795      795           
=======================================
  Hits          450      450           
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teutoburg teutoburg added the tests Related to unit or integration tests label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Related to unit or integration tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants