Skip to content

Update AppInfoHelper.java fixes crash on Android > 13 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AppInfoHelper.java fixes crash on Android > 13 #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions app/src/main/java/org/asteroidos/sync/utils/AppInfoHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
import android.graphics.drawable.BitmapDrawable;
import android.util.Log;

import org.asteroidos.sync.R;

import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
Expand Down Expand Up @@ -65,12 +67,25 @@ public static ArrayList<AppInfo> getPackageInfo(Context context)
"icon for %s had invalid height or width (h: %d w: %d)",
pinfo.packageName, src.getHeight(), src.getWidth()));
}
}
else {
icon = Bitmap.createBitmap(apkIcon.getIntrinsicWidth(), apkIcon.getIntrinsicHeight(), Bitmap.Config.ARGB_8888);
Canvas canvas = new Canvas(icon);
apkIcon.setBounds(0, 0, canvas.getWidth(), canvas.getHeight());
apkIcon.draw(canvas);
} else {
if (apkIcon.getIntrinsicWidth() <= 0 || apkIcon.getIntrinsicHeight() <= 0) {
Log.e("BitmapDebug", "Invalid dimensions! Width or height is not positive.");
// Handle the error appropriately:
// - Return a default bitmap
// - Skip this bitmap creation
// - Throw a custom exception with more context
// - etc.
apkIcon = context.getResources().getDrawable(R.drawable.introslide1icon);
icon = Bitmap.createBitmap(apkIcon.getIntrinsicWidth(), apkIcon.getIntrinsicHeight(), Bitmap.Config.ARGB_8888);
Canvas canvas = new Canvas(icon);
apkIcon.setBounds(0, 0, canvas.getWidth(), canvas.getHeight());
apkIcon.draw(canvas);
} else {
icon = Bitmap.createBitmap(apkIcon.getIntrinsicWidth(), apkIcon.getIntrinsicHeight(), Bitmap.Config.ARGB_8888);
Canvas canvas = new Canvas(icon);
apkIcon.setBounds(0, 0, canvas.getWidth(), canvas.getHeight());
apkIcon.draw(canvas);
}
}
} catch(ClassCastException ignored) {}
AppInfo appInfo = new AppInfo(pinfo.packageName,
Expand Down