Separate the web runner from eframe and update egui#170
Merged
melody-rs merged 18 commits intoAstrabit-ST:devfrom Jul 27, 2025
Merged
Separate the web runner from eframe and update egui#170melody-rs merged 18 commits intoAstrabit-ST:devfrom
melody-rs merged 18 commits intoAstrabit-ST:devfrom
Conversation
This allows for removing the forked versions of eframe and egui-wgpu.
(See white-axe/mkxp-z-libretro-emscripten@2c92d6e) In Firefox, service workers have an idle timeout of 30 seconds by default. If they spend more than 30 seconds idle (e.g. fetching files from the Internet) without receiving any messages from the main thread, Firefox will kill them. This is a workaround for that for users with slow connections.
Collaborator
Author
|
I've added egui-modal as a vendored crate so that egui can be updated past 0.30.0. Since egui starting from version 0.32.0 requires rustc 1.85 or later and some of idna's dependencies now require rustc 1.82 or later, I've updated the nightly toolchain used by the builds to 2025-01-04, the first one from after rustc 1.85. The toolchain also needs to be updated in luminol-website or it'll fail to build. |
Collaborator
Author
|
It was actually the default font size of the toasts changing. I've changed the font size back to the original one. |
melody-rs
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This pull request moves the custom web runner used by Luminol back into a self-contained set of files like it was before #70 to make it easier to update egui, removes the custom eframe and egui-wgpu crates and updates egui to 0.32.0 and wgpu to 25.0.2.
Testing
All the functionality that was previously managed by the web runner should still work:
ctx.options_mut(|o| o.screen_reader = true)anywhere and then focusing buttons or labels in the user interface)Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release