fix(rustowl): Rustowl build failure

[Yoshiboi18303]

Change lua/astrocommunity/editing-support/rustowl/init.lua build command to use cargo binstall or cargo install. Compared to running cd rustowl, which doesn't work at all.

📑 Description

This pull request should fix an issue with the rustowl plugin in astrocommunity.editing-support.rustowl spec. Originally it would try to run cd rustowl && cargo install --path . --locked in the build part, which fails at the first command with (the error depends on your shell):

zsh:cd no such file or directory: rustowl

This uses cargo directly by either running cargo binstall or cargo install if the cargo-binstall crate isn't installed.

📖 Additional Information

[github-actions]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

• Proper usage of opts table rather than setting things up with the config function.

• Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

[Yoshiboi18303]

This is one of my first pull requests to this repo, so... if anything is wrong, please let me know.

[Yoshiboi18303]

Fixed the title, it was incorrect. My bad guys!

[Uzaaft]

Remove binstall, most rust users probably dont have it installed anyways. And installing pre-compiled binaries on the users machine smells.

[Yoshiboi18303]

Gotcha, I'll get back with a change. Running cargo install directly may raise an issue with Lazy having a build timeout (as when I ran it with like 16 CPU cores, it timed out and the process was killed, so the build failed), so I may have to update the README to say as such.

[Yoshiboi18303]

Attempting to find out how to increase the build timeout, stand by.

[Yoshiboi18303]

Found it, just gotta review and make sure it's right.

[Yoshiboi18303]

Done.

[Yoshiboi18303]

Forgot to use --locked, fixed that.

[Uzaaft]

Would this work if the user doesnt have a nightly toolchain? Does cargo install respect the rust-toolchain file upstream?

[Yoshiboi18303]

It should, I'll test it now.

[Yoshiboi18303]

Yeah, it works off nightly. It's broken on nightly though, but that's probably their code not being fit for nightly.

[Yoshiboi18303]

Here's a recording of me building it with Nightly Rust.

[Yoshiboi18303]

Probably not a big deal though, most people use stable, including me.