Skip to content

Conversation

@Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jan 19, 2025

  • Flake.nix and lock for devShell
  • .envrc for direnv
  • Ignore .direnv folder

- Flake.nix and lock for devShell
- .envrc for direnv
- Ignore .direnv folder
@netlify
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for peaceful-platypus-6db452 ready!

Name Link
🔨 Latest commit 041d239
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-platypus-6db452/deploys/678d24c8e797d50008e5402a
😎 Deploy Preview https://deploy-preview-169--peaceful-platypus-6db452.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89
Accessibility: 98
Best Practices: 100
SEO: 93
PWA: 90
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the .envrc file and leave that up to the user. Also we shouldn't force install Alejandra since that's not part of the base project. The only hard requirements are node and pnpm. Anything outside of that should be up to the user

@Uzaaft
Copy link
Member Author

Uzaaft commented Jan 19, 2025

I think we should remove the .envrc file and leave that up to the user. Also we shouldn't force install Alejandra since that's not part of the base project. The only hard requirements are node and pnpm. Anything outside of that should be up to the user

The .envrc file leaves it up to the user. You dont want to use it, dont run direnv allow.

Also I just added alejandra to format nix flakes in case people make more changes to it and adds stuff. I can remove it if needed.

@mehalter
Copy link
Member

Okay, we can leave the direnv stuff. We should probably also add .tool-versions for node and pnpm for ASDF and mise support. Also yeah definitely need to remove alejandra

@Uzaaft
Copy link
Member Author

Uzaaft commented Jan 19, 2025

Fixed. R? @mehalter

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove alejandra

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and fixed the rest of the alejandra removal and added a .tool-versions for more dev environment support.

@mehalter mehalter merged commit 2f2f31c into main Jan 19, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants