-
Notifications
You must be signed in to change notification settings - Fork 67
feat(build): Add in nix flake for devShell #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uzaaft
commented
Jan 19, 2025
- Flake.nix and lock for devShell
- .envrc for direnv
- Ignore .direnv folder
- Flake.nix and lock for devShell - .envrc for direnv - Ignore .direnv folder
✅ Deploy Preview for peaceful-platypus-6db452 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mehalter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the .envrc file and leave that up to the user. Also we shouldn't force install Alejandra since that's not part of the base project. The only hard requirements are node and pnpm. Anything outside of that should be up to the user
The .envrc file leaves it up to the user. You dont want to use it, dont run direnv allow. Also I just added alejandra to format nix flakes in case people make more changes to it and adds stuff. I can remove it if needed. |
|
Okay, we can leave the direnv stuff. We should probably also add |
|
Fixed. R? @mehalter |
mehalter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove alejandra
mehalter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and fixed the rest of the alejandra removal and added a .tool-versions for more dev environment support.
