Skip to content

Conversation

@sashimikun
Copy link

This change updates the Jules Agent SDK to support the new AUTO_CREATE_PR automation mode. It adds an optional automation_mode parameter to the sessions.create method, allowing users to create sessions that automatically generate a pull request upon completion.

This change updates the Jules Agent SDK to support the new AUTO_CREATE_PR automation mode. It adds an optional automation_mode parameter to the sessions.create method, allowing users to create sessions that automatically generate a pull request upon completion.
@gemini-code-assist
Copy link

Summary of Changes

Hello @sashimikun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the AUTO_CREATE_PR automation mode within the Jules Agent SDK. It enables users to configure sessions that automatically generate a pull request upon completion by adding an automation_mode parameter to the session creation process, enhancing the SDK's capabilities for automated workflows.

Highlights

  • Model Update: The Session model in src/jules_agent_sdk/models.py has been updated to include an optional automation_mode field, which is a string representing the automation mode for a session.
  • API Method Enhancement: The sessions.create method in src/jules_agent_sdk/sessions.py now accepts an optional automation_mode parameter, allowing users to specify the desired automation behavior when creating a new session.
  • New Test Case: A new test case, test_sessions_create_with_automation_mode, has been added to tests/test_client.py to ensure that sessions can be successfully created with the AUTO_CREATE_PR automation mode and that the parameter is correctly passed in the API request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the AUTO_CREATE_PR automation mode when creating a session. The changes are well-implemented across the data models, API methods, and tests. The new automation_mode parameter is added to sessions.create, and a corresponding test case verifies its functionality. My main feedback is a suggestion to use an Enum for automation_mode to improve type safety and maintainability, which I've detailed in a specific comment.

name: str = ""
id: str = ""
title: str = ""
automation_mode: Optional[str] = None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better type safety and maintainability, consider defining an Enum for automation_mode. This prevents typos and makes it clear what values are supported by the API. If AUTO_CREATE_PR is the only mode for now, you can start with that.

For example:

from enum import Enum

class AutomationMode(str, Enum):
    """Automation mode for a session."""
    AUTO_CREATE_PR = "AUTO_CREATE_PR"

# Then in the Session class:
...
    automation_mode: Optional[AutomationMode] = None
...

# In from_dict:
...
automation_mode_str = data.get("automationMode")
automation_mode = AutomationMode(automation_mode_str) if automation_mode_str else None
...

# In to_dict:
...
if self.automation_mode:
    result["automationMode"] = self.automation_mode.value
...

You would also need to update the sessions.create method signature to accept Optional[AutomationMode] and pass its value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant