-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add support for AUTO_CREATE_PR automation mode #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change updates the Jules Agent SDK to support the new AUTO_CREATE_PR automation mode. It adds an optional automation_mode parameter to the sessions.create method, allowing users to create sessions that automatically generate a pull request upon completion.
Summary of ChangesHello @sashimikun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the AUTO_CREATE_PR automation mode when creating a session. The changes are well-implemented across the data models, API methods, and tests. The new automation_mode parameter is added to sessions.create, and a corresponding test case verifies its functionality. My main feedback is a suggestion to use an Enum for automation_mode to improve type safety and maintainability, which I've detailed in a specific comment.
| name: str = "" | ||
| id: str = "" | ||
| title: str = "" | ||
| automation_mode: Optional[str] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better type safety and maintainability, consider defining an Enum for automation_mode. This prevents typos and makes it clear what values are supported by the API. If AUTO_CREATE_PR is the only mode for now, you can start with that.
For example:
from enum import Enum
class AutomationMode(str, Enum):
"""Automation mode for a session."""
AUTO_CREATE_PR = "AUTO_CREATE_PR"
# Then in the Session class:
...
automation_mode: Optional[AutomationMode] = None
...
# In from_dict:
...
automation_mode_str = data.get("automationMode")
automation_mode = AutomationMode(automation_mode_str) if automation_mode_str else None
...
# In to_dict:
...
if self.automation_mode:
result["automationMode"] = self.automation_mode.value
...You would also need to update the sessions.create method signature to accept Optional[AutomationMode] and pass its value.
This change updates the Jules Agent SDK to support the new AUTO_CREATE_PR automation mode. It adds an optional automation_mode parameter to the sessions.create method, allowing users to create sessions that automatically generate a pull request upon completion.