-
-
Notifications
You must be signed in to change notification settings - Fork 10
📚 Update CONTRIBUTING.md (#1625) #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CONTRIBUTING.md (2)
29-30: LGTM! Consider adding migration guide links.The framework versions are correctly updated, and the note about Runes is helpful. Consider adding links to the official migration guides to help contributors:
- Svelte 5 Preview: https://svelte.dev/blog/svelte-5-preview
- SvelteKit 2.0: https://kit.svelte.dev/docs/migrating-to-sveltekit-2
33-33: Consider listing alternative UI libraries.While the note about STWUI's potential discontinuation is helpful, it would be more actionable to list specific alternative libraries that contributors should consider for the migration.
Consider adding a list of potential alternatives, for example:
- - [STWUI](https://stwui.vercel.app/): 開発が事実上終了した可能性が高いため、使用しているコンポーネントを調べて別のライブラリに移行する + - [STWUI](https://stwui.vercel.app/): 開発が事実上終了した可能性が高いため、使用しているコンポーネントを以下のライブラリのいずれかに移行する予定: + - [Skeleton](https://www.skeleton.dev/) + - [DaisyUI](https://daisyui.com/) + - [Melt UI](https://melt-ui.com/)
close #1625
Summary by CodeRabbit
CONTRIBUTING.md