-
-
Notifications
You must be signed in to change notification settings - Fork 10
🎨 Hide replenished workbooks by default (#1708) #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the default state for displaying replenishment workbooks in the WorkBookList Svelte component. The variable "isShowReplenishment" is now initialized as false instead of true, which means the replenishment section will be hidden by default. This alteration affects the UI logic by changing the initial visibility setting for supplemental workbooks. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/lib/components/WorkBooks/WorkBookList.svelte (1)
111-113: Consider adding a tooltip to explain the toggle's purpose.The toggle's label "「補充」があれば表示" could benefit from a tooltip explaining what "補充" (replenishment) workbooks are, similar to how you've added tooltips for other UI elements.
Consider wrapping the Toggle with TooltipWrapper like this:
<div class="mt-4 md:mt-0"> + <TooltipWrapper tooltipContent="補充問題集の表示/非表示を切り替えます"> <Toggle bind:checked={isShowReplenishment}>「補充」があれば表示</Toggle> + </TooltipWrapper> </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/lib/components/WorkBooks/WorkBookList.svelte(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: preview
🔇 Additional comments (1)
src/lib/components/WorkBooks/WorkBookList.svelte (1)
60-60: LGTM! The change aligns with the PR objective.The initialization of
isShowReplenishmenttofalseeffectively hides the replenished workbooks by default, which is the intended behavior as per PR #1708.This change:
- Makes the UI cleaner by default
- Still allows users to view replenished workbooks via the toggle when needed
- Maintains all existing functionality while improving the initial user experience
close #1708
Summary by CodeRabbit